After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677999 - album art not shown in many cases (since move to mb4)
album art not shown in many cases (since move to mb4)
Status: RESOLVED FIXED
Product: sushi
Classification: Core
Component: libsushi
0.5.x
Other Linux
: Normal normal
: ---
Assigned To: Sushi maintainer(s)
Sushi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-06-13 10:57 UTC by Jon Dowland
Modified: 2012-07-16 20:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to up the MB query limit (1.01 KB, patch)
2012-06-13 10:59 UTC, Jon Dowland 		committed Details | Review

Description Jon Dowland 2012-06-13 10:57:53 UTC 
When you moved to musicbrainz4, you set the limit on responses to queries to '1'.

The first response to many queries is a record without an ASIN: e.g. Nirvana: Nevermind, Prodigy: Experience, many more.

Switching the limit to an arbitrary but higher number (10?) means the subsequent loop for records with ASINs has more to work with, and cures the album art query issue for the albums I've tried it with.
Comment 1 Jon Dowland 2012-06-13 10:59:12 UTC 
Created attachment 216255 [details] [review]
patch to up the MB query limit
Comment 2 Cosimo Cecchi 2012-06-13 13:27:44 UTC 
Review of attachment 216255 [details] [review]:

Looks fine...does this somehow increase the chance of false positives?
Comment 3 Cosimo Cecchi 2012-06-13 13:27:44 UTC 
Review of attachment 216255 [details] [review]:

Looks fine...does this somehow increase the chance of false positives?
Comment 4 Cosimo Cecchi 2012-07-16 20:42:15 UTC 
Pushed this to master for today's 0.5.4 release.