After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677983 - EvAnnotation is using GdkColor
EvAnnotation is using GdkColor
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
2.31.x
Other Linux
: Normal enhancement
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-12 22:56 UTC by Christian Persch
Modified: 2012-06-24 14:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Christian Persch 2012-06-12 22:56:02 UTC 
EvAnnotation is using the deprecated GdkColor (and EvAnnotationMarkup is storing a separate opacity double). Instead, there should be a GdkRGBA property on EvAnnotation, and the color and opacity properties and accessors be deprecated.

There is a problem in that the poppler API use a GdkColor-lookalike called PopplerColor instead of a GdkRGBA-lookalike. This needs to be fixed in poppler.
Comment 1 Carlos Garcia Campos 2012-06-13 10:48:39 UTC 
Can't we just convert the PopplerColor to GdkRGBA en ev-poppler?
Comment 2 Christian Persch 2012-06-13 11:44:31 UTC 
Of course we can :-) I just think it'd be nicer to use only one colour representation in the whole stack, and I think GdkRGBA is that one.
Comment 3 Carlos Garcia Campos 2012-06-13 12:14:49 UTC 
The thing is that poppler doesn't depend on Gdk, so we would need to convert the color anyway. Or do you mean adding PopplerRGBA struct with exactly the same members than GdkRGBA? so that we can just cast instead of convert?
Comment 4 Christian Persch 2012-06-13 12:24:12 UTC 
Yes, exactly that, a cast-compatible PopplerRGBA.