After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677969 - network: crash while switching tabs
network: crash while switching tabs
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other Linux
: Normal critical
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 654014 660569 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-06-12 19:00 UTC by Matthias Clasen
Modified: 2014-12-15 17:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
stacktrace (6.86 KB, text/plain)
2012-06-12 19:00 UTC, Matthias Clasen
  Details
network: avoid crashes due to leftover signal handlers (2.18 KB, patch)
2012-06-28 03:03 UTC, Matthias Clasen
none Details | Review

Description Matthias Clasen 2012-06-12 19:00:31 UTC
Created attachment 216227 [details]
stacktrace

The stacktrace makes it fairly obvious that we are not really serious about cleaning up all the signal handlers and idles we have here...
Comment 1 Matthias Clasen 2012-06-28 03:02:58 UTC
Way to reproduce the crash:

1. open network panel
2. switch to a different panel (or just to the overview)
3. select a different wifi ap in the shell menu
4. control-center crashes
Comment 2 Matthias Clasen 2012-06-28 03:03:29 UTC
Created attachment 217473 [details] [review]
network: avoid crashes due to leftover signal handlers

The libnm objects can survive the disposal of the network panel.
If we don't disconnect the signal handlers on them, bad things
can happen. Use g_signal_connect_object to tie the life-cycle
of the signal handlers to the panel.
Comment 3 Richard Hughes 2012-06-28 12:47:59 UTC
Looks good to me, thanks. Pushed to master.
Comment 4 Bastien Nocera 2013-04-18 15:27:37 UTC
*** Bug 654014 has been marked as a duplicate of this bug. ***
Comment 5 André Klapper 2014-12-15 17:59:47 UTC
*** Bug 660569 has been marked as a duplicate of this bug. ***