After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677954 - user-accounts: Properly fill the join prompt dialog
user-accounts: Properly fill the join prompt dialog
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-12 15:20 UTC by Stef Walter
Modified: 2012-06-13 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
user-accounts: Properly fill the join prompt dialog (2.00 KB, patch)
2012-06-12 15:20 UTC, Stef Walter 		reviewed Details | Review
user-accounts: Properly fill the join prompt dialog (2.01 KB, patch)
2012-06-13 10:47 UTC, Stef Walter 		accepted-commit_now Details | Review

Description Stef Walter 2012-06-12 15:20:33 UTC 
The join prompt for administrative credentials wasn't being
prefilled with the administrator name the first time. In addition
errors were shown the first time, which should only be shown
on later iterations.
Comment 1 Stef Walter 2012-06-12 15:20:35 UTC 
Created attachment 216213 [details] [review]
user-accounts: Properly fill the join prompt dialog

When prompting users for administrative domain credentials,
correctly fill the dialog the first time the prompt is shown.
Comment 2 Matthias Clasen 2012-06-13 10:33:33 UTC 
Review of attachment 216213 [details] [review]:

::: panels/user-accounts/um-account-dialog.c
@@ +92,3 @@
         GtkEntry *join_name;
         GtkEntry *join_password;
+        gint join_prompts;

Do we need to count here, or could this just be a boolean ?
Comment 3 Stef Walter 2012-06-13 10:47:42 UTC 
Created attachment 216254 [details] [review]
user-accounts: Properly fill the join prompt dialog

Sure, it could be a boolean. I don't really care either way.
Here you go.
Comment 4 Matthias Clasen 2012-06-13 18:20:54 UTC 
pushed as 2589fcfb19683c9d02da835deab9d4a1c45c2c4e