After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677949 - [new roster] Remove old preferences
[new roster] Remove old preferences
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Preferences
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks: 669484
 
 
Reported: 2012-06-12 14:02 UTC by Guillaume Desmottes
Modified: 2012-06-15 11:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
roster-window: remove unused gsettings_contacts (2.15 KB, patch)
2012-06-14 08:29 UTC, Guillaume Desmottes
committed Details | Review
remove deprecated gsettings keys (13.08 KB, patch)
2012-06-14 08:29 UTC, Guillaume Desmottes
committed Details | Review
preferences: add UI to show/hide groups (2.58 KB, patch)
2012-06-14 08:29 UTC, Guillaume Desmottes
committed Details | Review
Don't show groups by default (1.07 KB, patch)
2012-06-14 08:29 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2012-06-12 14:02:19 UTC
Once we have switched to the new roster (bug #677948) we should remove the old preferences which don't make sense with the new UI.
Comment 1 Guillaume Desmottes 2012-06-14 08:29:01 UTC
Created attachment 216385 [details] [review]
roster-window: remove unused gsettings_contacts
Comment 2 Guillaume Desmottes 2012-06-14 08:29:04 UTC
Created attachment 216386 [details] [review]
remove deprecated gsettings keys

Those are not supported by the new roster UI and so can be removed.
Comment 3 Guillaume Desmottes 2012-06-14 08:29:07 UTC
Created attachment 216387 [details] [review]
preferences: add UI to show/hide groups

I'm about to change the default to not show groups, so users should have an
easy way to get them back.
I just removed a bunch of options from the preferences dialog so at the end it
will still be simpler than it used to be.
Comment 4 Guillaume Desmottes 2012-06-14 08:29:09 UTC
Created attachment 216388 [details] [review]
Don't show groups by default

The new design is less groups oriented. Users can easly get them back using
the preferences dialog.
Comment 5 Danielle Madeley 2012-06-15 02:54:15 UTC
Review of attachment 216385 [details] [review]:

++
Comment 6 Danielle Madeley 2012-06-15 02:55:19 UTC
Review of attachment 216386 [details] [review]:

++
Comment 7 Danielle Madeley 2012-06-15 02:57:15 UTC
Review of attachment 216387 [details] [review]:

++
Comment 8 Danielle Madeley 2012-06-15 02:57:36 UTC
Review of attachment 216388 [details] [review]:

++
Comment 9 Guillaume Desmottes 2012-06-15 11:47:43 UTC
Attachment 216385 [details] pushed as 368556a - roster-window: remove unused gsettings_contacts
Attachment 216386 [details] pushed as a27a6f8 - remove deprecated gsettings keys
Attachment 216387 [details] pushed as 5218900 - preferences: add UI to show/hide groups
Attachment 216388 [details] pushed as 9ef2bba - Don't show groups by default