After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677899 - Can not edit options when no connection for the selected device available
Can not edit options when no connection for the selected device available
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-11 21:02 UTC by Thomas Bechtold
Modified: 2012-06-18 10:41 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6

Attachments
find Connection with specific MAC address set (10.39 KB, patch)
2012-06-11 22:57 UTC, Thomas Bechtold 		needs-work Details | Review
updated patch (8.73 KB, patch)
2012-06-17 15:27 UTC, Thomas Bechtold 		none Details | Review
updated patch (add copyright statement) (9.10 KB, patch)
2012-06-17 15:30 UTC, Thomas Bechtold 		none Details | Review

Description Thomas Bechtold 2012-06-11 21:02:36 UTC 
i have a ethernet device but no NM ethernet connection in /etc/NetworkManager/system-connections . When i select the device and press "options", i get:

(gnome-control-center:9919): network-cc-panel-WARNING **: failed to find connection for device
Comment 1 Thomas Bechtold 2012-06-11 22:57:58 UTC 
Created attachment 216161 [details] [review]
find Connection with specific MAC address set
Comment 2 Richard Hughes 2012-06-12 15:10:41 UTC 
Review of attachment 216161 [details] [review]:

In concept, I like it, thanks. General points:

* a lot of the lines are waaay too long, aim for 80 wide please

                 if (g_slist_length (filtered) == 1)
+                {

Brace on the same line as the "if" please

+                        case NM_DEVICE_TYPE_WIFI:
+                        {
+                                gchar* mac = get_mac_address_of_connection (connection);

If they are all declaring mac* then please move this up in the scope, then you can drop the extra { and }.

+                        default:
+                        {
+                                break;
+                        }

No need for the extra braces here.
Comment 3 Thomas Bechtold 2012-06-17 15:27:08 UTC 
Created attachment 216606 [details] [review]
updated patch
Comment 4 Thomas Bechtold 2012-06-17 15:30:00 UTC 
Created attachment 216607 [details] [review]
updated patch (add copyright statement)
Comment 5 Thomas Bechtold 2012-06-18 10:41:07 UTC 
fixed in git master (806b3e0e13ec63edeb5f635e67dc5a2cd798bd62)