After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677782 - Install bash completion files in /usr/share
Install bash completion files in /usr/share
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gdbus
2.32.x
Other Linux
: Normal normal
: ---
Assigned To: David Zeuthen (not reading bugmail)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-06-10 03:07 UTC by xecycle
Modified: 2012-06-21 10:23 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description xecycle 2012-06-10 03:07:03 UTC
Bash completion script should be installed as "gdbus", but is installed as "gdbus-bash-completion.sh" in version 2.32.3.  It doesn't work with this name.
Comment 1 Matthias Clasen 2012-06-10 03:22:56 UTC
works fine here
Comment 2 xecycle 2012-06-10 03:36:50 UTC
(In reply to comment #1)
> works fine here

What's the name of this script in your installation?
Comment 3 David Zeuthen (not reading bugmail) 2012-06-10 15:04:06 UTC
The name doesn't matter one bit, what matters is that the script is sourced at login time. As it's installed into /etc/bash_completion.d you will need something to source it. On Fedora that's done by the bash-completion package. Without that package completion won't work.

Hope tis helps.

There is no bug here so closing.
Comment 4 xecycle 2012-06-10 15:25:30 UTC
(In reply to comment #3)
> The name doesn't matter one bit, what matters is that the script is sourced at
> login time. As it's installed into /etc/bash_completion.d you will need
> something to source it. On Fedora that's done by the bash-completion package.
> Without that package completion won't work.
> 
> Hope tis helps.
> 
> There is no bug here so closing.

Not exactly.  On Arch we install them to /usr/share/bash-completion/completions, and sourced by name by /usr/share/bash-completion/bash_completion; this script is found in upstream.  It depends on the name.  So --- bash-completion upstream authors source completion scripts by name, and we don't have the right name here.
Comment 5 Matthias Clasen 2012-06-10 21:09:46 UTC
Sounds like a bash-completion api change to me. But if you already install the script somewhere else, it should not be too hard for you to rename it at the same time.
Comment 6 Allison Karlitskaya (desrt) 2012-06-10 23:49:02 UTC
imho, I'd actually be happier for us to install the scripts into /usr/share instead of /etc.  /etc is for configuration data (which this is decidedly not).

If there's a standard way of doing that, perhaps we should use it.  Checking upstream I do indeed see that there is an effort being made to move in that direction, so we should follow.
Comment 7 Matthias Clasen 2012-06-12 01:33:17 UTC
Sure.
Comment 8 Matthias Clasen 2012-06-15 23:05:10 UTC
So, this is a fairly recent change:

 -- David Paleino <d.paleino@gmail.com>  Sat, 07 Jan 2012 23:52:36 +0100

bash-completion (1.90)

  * Layout change: everything is now in /usr/share/bash-completion/, rather
    than in /etc/.
Comment 9 Ulf Winkelvos 2012-06-20 19:59:26 UTC
/usr/share/bash-completion/completions/dconf-bash-completion.sh is owned by dconf 0.12.1-2
/usr/share/bash-completion/completions/gdbus-bash-completion.sh is owned by glib2 2.32.3-1
/usr/share/bash-completion/completions/gresource-bash-completion.sh is owned by glib2 2.32.3-1
/usr/share/bash-completion/completions/gsettings-bash-completion.sh is owned by glib2 2.32.3-1
/usr/share/bash-completion/completions/gvfs-bash-completion.sh is owned by gvfs 1.12.3-2
---

At least those scripts should be renamed too. Do we need sepereate bug reports for them?