After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677725 - Patch for Evolution-Data-Server API changes
Patch for Evolution-Data-Server API changes
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-06-08 20:03 UTC by Matthew Barnes
Modified: 2012-08-20 08:49 UTC
See Also:
GNOME target: 3.6
GNOME version: ---


Attachments
Adapt to Evolution-Data-Server API changes (20.15 KB, patch)
2012-06-08 20:03 UTC, Matthew Barnes
none Details | Review
More adaption to EDS API changes (4.88 KB, patch)
2012-06-13 14:10 UTC, Florian Müllner
none Details | Review

Description Matthew Barnes 2012-06-08 20:03:15 UTC
Created attachment 215987 [details] [review]
Adapt to Evolution-Data-Server API changes

Evolution-Data-Server just landed some major API changes in an effort to get
off of GConf and overhaul the way it stores account information.

I blogged about this recently with more details:
http://mbarnes.livejournal.com/4631.html

This is an untested patch since I guess I don't have a new enough vala or something.  The EDS part builds fine.  Most of the crap is gone, what remains is pretty straight forward.  You might just want to rewrite it all directly in vala.
Comment 1 Florian Müllner 2012-06-13 14:10:37 UTC
Created attachment 216283 [details] [review]
More adaption to EDS API changes

This makes Contacts compile again, though it's still broken when
running it ...

Feel free to squash this. I'm afraid to actually fix the functionality, someone with a better understanding of e-d-s and/or contacts will be better suited than me ...
Comment 2 Alexander Larsson 2012-06-14 20:59:53 UTC
I pushed something based on this, but I can't really test it at runtime because the folks eds backend is totally busted and just spews warnings all over the place.
Comment 3 Guillaume Desmottes 2012-06-28 06:56:48 UTC
master doesn't build here:


In file included from /home/cassidy/usr/include/folks/folks-eds.h:12:0,
                 from contacts-app.c:31:
/home/cassidy/usr/include/evolution-data-server-3.6/libebook/e-book-client.h:23:2: error: #error "Only <libebook/libebook.h> should be included directly."
In file included from /home/cassidy/usr/include/evolution-data-server-3.6/libebook/e-book-client.h:31:0,
                 from /home/cassidy/usr/include/folks/folks-eds.h:12,
                 from contacts-app.c:31:
/home/cassidy/usr/include/evolution-data-server-3.6/libebook/e-book-client-view.h:22:2: error: #error "Only <libebook/libebook.h> should be included directly."
In file included from /home/cassidy/usr/include/evolution-data-server-3.6/libebook/e-book-client.h:32:0,
                 from /home/cassidy/usr/include/folks/folks-eds.h:12,
                 from contacts-app.c:31:
/home/cassidy/usr/include/evolution-data-server-3.6/libebook/e-contact.h:10:2: error: #error "Only <libebook/libebook.h> should be included directly."
In file included from /home/cassidy/usr/include/evolution-data-server-3.6/libebook/e-contact.h:18:0,
                 from /home/cassidy/usr/include/evolution-data-server-3.6/libebook/e-book-client.h:32,
                 from /home/cassidy/usr/include/folks/folks-eds.h:12,
                 from contacts-app.c:31:
/home/cassidy/usr/include/evolution-data-server-3.6/libebook/e-vcard.h:24:2: error: #error "Only <libebook/libebook.h> should be included directly."
In file included from contacts-app.c:31:0:
/home/cassidy/usr/include/folks/folks-eds.h:13:38: fatal error: libedataserver/e-account.h: No such file or directory
compilation terminated.
Comment 4 Guillaume Desmottes 2012-06-28 07:02:26 UTC
My folks is not 100% up to date as I can't build it atm (bug #679020) but Contact's configure did pass.
Comment 5 Alexander Larsson 2012-06-29 08:30:35 UTC
Weird. It builds fine here.
Comment 6 Alexander Larsson 2012-08-20 08:49:02 UTC
works for me and others, open a new bug if it still fails to build