After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677659 - add user_data parameter to ClutterBindingActionFunc
add user_data parameter to ClutterBindingActionFunc
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks: 669815
 
 
Reported: 2012-06-07 23:28 UTC by Evan Nemerson
Modified: 2012-06-09 20:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
binding-pool: add user_data parameter to ClutterBindingActionFunc (1.17 KB, patch)
2012-06-07 23:29 UTC, Evan Nemerson 		accepted-commit_now Details | Review

Description Evan Nemerson 2012-06-07 23:28:07 UTC 
The ClutterBindingActionFunc is missing a user_data parameter as a final argument.  The argument is correctly passed (see the _clutter_marshal_BOOLEAN__STRING_UINT_FLAGS function in clutter-marshal.c) already, it is just missing from the typedef.

ClutterBindingActionFunc is not actually used in C (the arguments which could/should be ClutterBindingActionFunc are GCallback right now) so I don't think this should be considered an API break.
Comment 1 Evan Nemerson 2012-06-07 23:29:08 UTC 
Created attachment 215884 [details] [review]
binding-pool: add user_data parameter to ClutterBindingActionFunc
Comment 2 Emmanuele Bassi (:ebassi) 2012-06-08 14:58:44 UTC 
Review of attachment 215884 [details] [review]:

strictly speaking, no: it's not an API break; the symbol was added mostly for documentation purposes. it's a small source compatibility break: people using the symbol to pass around functions will now warn about a different function signature. nevertheless, I think it's worth doing this before 2.0 anyway - after all, annotating a symbol for deprecation is a source compatibility break.
Comment 3 Evan Nemerson 2012-06-09 20:28:45 UTC 
commit 0a5967ef503aebf020fb084a13dd8b6851a7d813
Author: Evan Nemerson <evan@coeus-group.com>
Date:   Thu Jun 7 16:22:03 2012 -0700

    binding-pool: add user_data parameter to ClutterBindingActionFunc
    
    https://bugzilla.gnome.org/show_bug.cgi?id=677659