After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677638 - Gnect icon shows impossible game situation
Gnect icon shows impossible game situation
Status: RESOLVED FIXED
Product: four-in-a-row
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: four-in-a-row-maint
four-in-a-row-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-07 17:12 UTC by Willem
Modified: 2014-09-05 20:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use a meaningful icon in the hicolor theme. (52.43 KB, patch)
2014-09-05 06:06 UTC, Arnaud B. 		committed Details | Review
Use a meaningful icon in the HighContrast theme. (13.14 KB, patch)
2014-09-05 19:00 UTC, Arnaud B. 		committed Details | Review

Description Willem 2012-06-07 17:12:04 UTC 
The icon shows a game that continued on even after the red player had already made four-in-a-row twice.
Comment 1 Arnaud B. 2014-09-05 06:06:12 UTC 
Created attachment 285451 [details] [review]
Use a meaningful icon in the hicolor theme.

I did it as-I-could, was it the good thing to do? Here is a patch for the hicolor theme (the usual one); the HighContrast theme needs another update.
Comment 2 Arnaud B. 2014-09-05 06:13:06 UTC 
Note: I don’t know where to test if it worked…
Comment 3 Michael Catanzaro 2014-09-05 14:17:50 UTC 
Comment on attachment 285451 [details] [review]
Use a meaningful icon in the hicolor theme.

Attachment 285451 [details] pushed as d07853d - Use a meaningful icon in the hicolor theme.

Looks good to me. Leaving this open since the HighContrast icon still needs to be fixed.
Comment 4 Arnaud B. 2014-09-05 19:00:53 UTC 
Created attachment 285518 [details] [review]
Use a meaningful icon in the HighContrast theme.

Here is the update of the HighContrast theme.
Comment 5 Michael Catanzaro 2014-09-05 20:27:36 UTC 
Super, thanks!