After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677618 - Detect glib utils
Detect glib utils
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.35
Other Linux
: Normal enhancement
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-07 11:16 UTC by Lionel Landwerlin
Modified: 2012-08-05 16:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch v1 (573 bytes, patch)
2012-06-07 11:16 UTC, Lionel Landwerlin 		rejected Details | Review

Description Lionel Landwerlin 2012-06-07 11:16:22 UTC 
Created attachment 215841 [details] [review]
Patch v1

The attached patch will detect path of glib-mkenums/genmarshall and allow the variable to be specified at configure time. This ease cross compilation.

Depends on : https://bugzilla.gnome.org/show_bug.cgi?id=677617
Comment 1 Tim-Philipp Müller 2012-06-07 11:34:07 UTC 
You could just have added that to the other bug (and it's more like the other bug depends on this one...) :)

I think this kind of thing should go into AG_GST_GLIB_CHECK , though I think I'd prefer it if we just added

  GLIB_GENMARSHAL=`$PKG_CONFIG --variable=glib_genmarshal glib-2.0`
  GOBJECT_QUERY=`$PKG_CONFIG --variable=gobject_query glib-2.0`
  GLIB_MKENUMS=`$PKG_CONFIG --variable=glib_mkenums glib-2.0`
  GLIB_COMPILE_RESOURCES=`$PKG_CONFIG --variable=glib_compile_resources gio-2.0`
  AC_SUBST(GLIB_GENMARSHAL)
  AC_SUBST(GOBJECT_QUERY)
  AC_SUBST(GLIB_MKENUMS)
  AC_SUBST(GLIB_COMPILE_RESOURCES)

there directly.
Comment 2 Tim-Philipp Müller 2012-06-07 11:35:58 UTC 
> You could just have added that to the other bug (and it's more like the other
> bug depends on this one...) :)

Never mind that comment, I misread the patches.
Comment 3 Tim-Philipp Müller 2012-08-05 15:47:34 UTC 
Comment on attachment 215841 [details] [review]
Patch v1

We're doing this ourselves now, with our own GLib check:


commit fa9ffbec8e2c0017b19bd8a153a24f1f84eaba82
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Sat Jun 16 20:01:49 2012 +0100

    gst-glib.m4: check for glib-mkenums and glib-genmarshal and allow them to be overridden
    
    Makes cross-compiling easier.
    
  https://bugzilla.gnome.org/show_bug.cgi?id=677620