After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677616 - Fails to build with gold and glib-2.32 du to underlinking
Fails to build with gold and glib-2.32 du to underlinking
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-07 11:11 UTC by Justin
Modified: 2012-06-08 11:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
underlinking patch (1.60 KB, patch)
2012-06-07 13:39 UTC, Justin 		committed Details | Review

Description Justin 2012-06-07 11:11:55 UTC 
recent changes in glib-2.32 deps in pkg-config files require addition of gmodule-2.0 to PKG_CHECK_MODULES otherwise linking with gold will fails:

  CCLD   gnome-panel
panel-applets-manager-dbus.c:430: error: undefined reference to 'g_module_error'
panel-applets-manager-dbus.c:442: error: undefined reference to 'g_module_close'
panel-applets-manager-dbus.c:420: error: undefined reference to 'g_module_open'
panel-applets-manager-dbus.c:428: error: undefined reference to 'g_module_symbol'
panel-applets-manager-dbus.c:423: error: undefined reference to 'g_module_error'
collect2: error: ld returned 1 exit status
make[4]: *** [panel-test-applets] Error 1
make[4]: *** Waiting for unfinished jobs....
panel-applets-manager-dbus.c:430: error: undefined reference to 'g_module_error'
panel-applets-manager-dbus.c:442: error: undefined reference to 'g_module_close'
panel-applets-manager-dbus.c:420: error: undefined reference to 'g_module_open'
panel-applets-manager-dbus.c:428: error: undefined reference to 'g_module_symbol'
panel-applets-manager-dbus.c:423: error: undefined reference to 'g_module_error'
collect2: error: ld returned 1 exit status
make[4]: *** [gnome-panel] Error 1

please find attached a patch addressing this issue.
Comment 1 André Klapper 2012-06-07 11:43:24 UTC 
Justin: The patch got lost...
Comment 2 Justin 2012-06-07 13:39:10 UTC 
Created attachment 215850 [details] [review]
underlinking patch
Comment 3 Vincent Untz 2012-06-08 11:49:57 UTC 
Comment on attachment 215850 [details] [review]
underlinking patch

Thanks!