Bug 677607 – Closing Mail Browser emits critical warnings

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 677607 - Closing Mail Browser emits critical warnings


Summary:	Closing Mail Browser emits critical warnings


Status:	RESOLVED FIXED

Product:	evolution
Classification:	Applications
Component:	Mailer
Version:	3.6.x (obsolete)
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	evolution-mail-maintainers
QA Contact:	Evolution QA team

URL:
Whiteboard:	evolution[webkit]

Depends on:
Blocks:

Reported:	2012-06-07 07:40 UTC by Milan Crha
Modified:	2013-09-13 01:06 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Fix (587 bytes, patch) 2012-06-08 09:44 UTC, Dan Vrátil	needs-work	Details \| Review
Fix (1.17 KB, patch) 2012-06-08 11:45 UTC, Dan Vrátil	committed	Details \| Review

Description Milan Crha 2012-06-07 07:40:12 UTC

When I view message source and close the newly opened window then these new critical warnings are shown on console.

(evolution:22994): GLib-CRITICAL **: g_hash_table_destroy: assertion `hash_table != NULL' failed

(evolution:22994): GLib-CRITICAL **: g_hash_table_destroy: assertion `hash_table != NULL' failed

(evolution:22994): GLib-CRITICAL **: g_hash_table_destroy: assertion `hash_table != NULL' failed

Comment 1 Dan Vrátil 2012-06-07 07:52:24 UTC

I'm unable to reproduce the warnings just by closing source view window. 

Is there a specific message that causes this? Is there any specific action you did before opening the source view?

Comment 2 Milan Crha 2012-06-07 17:33:01 UTC

I see it with message from bug #677608 (on IMAP account, already downloaded).

Comment 3 Dan Vrátil 2012-06-08 09:44:46 UTC

Created attachment 215923 [details] [review]
Fix

The warning comes from EStockRequest, which is not used much often, therefor I had troubles reproducing it with most of my messages :)

Comment 4 Milan Crha 2012-06-08 11:13:36 UTC

You might fix other errors, as these come for me from other place (see below), and I see them even with your patch applied.

+ Trace 230327

#0 g_logv
at gmessages.c line 661
#1 g_log
at gmessages.c line 792
#2 mail_part_itip_free
at e-mail-parser-itip.c line 84
#3 mail_part_free
at e-mail-part.c line 73
#4 e_mail_part_unref
at e-mail-part.c line 160
#5 unref_mail_part
at e-mail-part-list.c line 29
#6 g_slist_foreach
at gslist.c line 840
#7 g_slist_free_full
at gslist.c line 177
#8 e_mail_part_list_finalize
at e-mail-part-list.c line 41
#9 g_object_unref
at gobject.c line 3018
#10 mail_display_dispose
at e-mail-display.c line 291
#11 g_object_run_dispose
at gobject.c line 1061

Comment 5 Dan Vrátil 2012-06-08 11:45:58 UTC

Created attachment 215936 [details] [review]
Fix

Nice, two bugs with one patch :)

Apparently the GHashTable in itip formatter is constructed only when the list of sources is needed, otherwise the pointers are left null.

Comment 6 Milan Crha 2012-06-11 10:52:26 UTC

It's better, thanks. Please commit.

Comment 7 Dan Vrátil 2012-06-12 16:35:20 UTC

Committed to master as 0c25f646c8e5d1e8f0617e14949e824de6e7f1fb

http://git.gnome.org/browse/evolution/commit/?id=0c25f646c8e5d1e8f0617e14949e824de6e7f1fb