After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677578 - error in PCRE error code conversion
error in PCRE error code conversion
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gregex
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-06-06 19:54 UTC by Christian Persch
Modified: 2012-07-01 12:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
regex: Fix PCRE error code conversion (1.94 KB, patch)
2012-06-06 19:54 UTC, Christian Persch 		accepted-commit_now Details | Review

Description Christian Persch 2012-06-06 19:54:04 UTC 
In gregex.c:translate_compile_error(), 100 is first added to errcode and then there's a switch on the errcode. However, several case: labels were using the unshifted PCRE err codes instead of the shifted ones, which means that these cases were never hit.
Comment 1 Christian Persch 2012-06-06 19:54:58 UTC 
Created attachment 215769 [details] [review]
regex: Fix PCRE error code conversion

Use the shifted error codes for comparisions.
Comment 2 Matthias Clasen 2012-06-30 04:22:05 UTC 
Review of attachment 215769 [details] [review]:

Ugh, nice catch
Comment 3 Christian Persch 2012-07-01 12:01:09 UTC 
Pushed to master.