After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677559 - argument of Gdk.Keymap.map_virtual_modifiers is not correct in gdk-3.0.vapi
argument of Gdk.Keymap.map_virtual_modifiers is not correct in gdk-3.0.vapi
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-06-06 15:48 UTC by Peng Huang
Modified: 2012-09-10 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdk: fix GI annotation and document for {map,add}_virtual_modifiers (1.71 KB, patch)
2012-08-09 08:53 UTC, Daiki Ueno 		committed Details | Review

Description Peng Huang 2012-06-06 15:48:38 UTC 
argument of Gdk.Keymap.map_virtual_modifiers is not correct in gdk-3.0.vapi.

I think it should be changed from 
public bool map_virtual_modifiers (Gdk.ModifierType state) to public bool map_virtual_modifiers (ref Gdk.ModifierType state).
Comment 1 Evan Nemerson 2012-06-08 00:32:24 UTC 
This was fixed in 0.16
Comment 2 Peng Huang 2012-06-08 02:14:13 UTC 
I fount latest code is using out instead of ref. but actually the arg is in/out arg. I think ref is correct.
Comment 3 Evan Nemerson 2012-06-08 02:32:26 UTC 
They are marked as out (not inout) in gdk (see [1]), so would you mind taking the issue up with them? If it's wrong it should be fixed upstream so other GObject Introspection consumers can benefit, and I don't have any direct knowledge on the subject.

[1]: http://developer.gnome.org/gdk3/stable/gdk3-Keyboard-Handling.html#gdk-keymap-map-virtual-modifiers
Comment 4 Peng Huang 2012-06-08 02:36:39 UTC 
Move this issue to gtk
Comment 5 Peng Huang 2012-06-08 02:42:58 UTC 
I think the argument state of gdk_keymap_map_virtual_modifiers spshould be in out instead of out. It may cause problem in gobject-introspection consumers. Please fix it.
Comment 6 Daiki Ueno 2012-08-09 08:53:57 UTC 
Created attachment 220764 [details] [review]
gdk: fix GI annotation and document for {map,add}_virtual_modifiers
Comment 7 Rui Matos 2012-09-10 13:12:02 UTC 
(In reply to comment #6)
> Created an attachment (id=220764) [details] [review]
> gdk: fix GI annotation and document for {map,add}_virtual_modifiers

Seems good. Thanks for the patch

Attachment 220764 [details] pushed as 7937b5d - gdk: fix GI annotation and document for {map,add}_virtual_modifiers