After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677551 - a11y: fix a typo leading to a crash
a11y: fix a typo leading to a crash
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-06-06 13:25 UTC by Cosimo Cecchi
Modified: 2012-06-07 20:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
a11y: fix a typo leading to a crash (1.26 KB, patch)
2012-06-06 13:25 UTC, Cosimo Cecchi
none Details | Review

Description Cosimo Cecchi 2012-06-06 13:25:24 UTC
See commit for rationale.
Comment 1 Cosimo Cecchi 2012-06-06 13:25:27 UTC
Created attachment 215741 [details] [review]
a11y: fix a typo leading to a crash

text can't be NULL here, or we would have failed way earlier.
The original code from gail returned if the renderer text was NULL, and
we have to do that, or we'll end up calling e.g.
g_utf8_offset_to_pointer() on a NULL pointer.

https://bugzilla.redhat.com/show_bug.cgi?id=827930
Comment 2 Cosimo Cecchi 2012-06-07 20:51:50 UTC
Pushed to master.