GNOME Bugzilla – Bug 677545
Build with tp-glib GSEAL
Last modified: 2012-06-07 10:51:51 UTC
Needed to build with tp-glib master.
Created attachment 215742 [details] [review] protocol-chooser: use TpConnectionManagerProtocol accessors
Created attachment 215743 [details] [review] remove unused proxy hash and equal functions
Created attachment 215744 [details] [review] tp-chat: use TpProxy accessors
Created attachment 215745 [details] [review] connection-managers: use TpConnectionManager accessor
Created attachment 215746 [details] [review] account-widget: use TpConnectionManager accessors
Created attachment 215747 [details] [review] import-utils: use TpConnectionManager accessors
Created attachment 215748 [details] [review] account-settings: use TpConnectionManager accessors
Created attachment 215749 [details] [review] make empathy_account_settings_get() static
It doesn't cover everything; I still need to port the defaut value code but I want to have bug #676634 merged first.
Review of attachment 215744 [details] [review]: ::: libempathy/empathy-tp-chat.c @@ +1112,3 @@ "connection", conn, + "dbus-daemon", tp_proxy_get_dbus_daemon (conn_proxy), + "bus-name", tp_proxy_get_bus_name (conn_proxy), you can even remove conn_proxy since tp_proxy_* gets a gpointer in args instead of TpProxy* to avoid casting.
+1 for the rest
(In reply to comment #10) > Review of attachment 215744 [details] [review]: > > ::: libempathy/empathy-tp-chat.c > @@ +1112,3 @@ > "connection", conn, > + "dbus-daemon", tp_proxy_get_dbus_daemon (conn_proxy), > + "bus-name", tp_proxy_get_bus_name (conn_proxy), > > you can even remove conn_proxy since tp_proxy_* gets a gpointer in args instead > of TpProxy* to avoid casting. Fixed, thanks.
Attachment 215742 [details] pushed as 77ffbf2 - protocol-chooser: use TpConnectionManagerProtocol accessors Attachment 215743 [details] pushed as c9a2ff7 - remove unused proxy hash and equal functions Attachment 215744 [details] pushed as 9bccca3 - tp-chat: use TpProxy accessors Attachment 215745 [details] pushed as eb601e9 - connection-managers: use TpConnectionManager accessor Attachment 215746 [details] pushed as 56b41e3 - account-widget: use TpConnectionManager accessors Attachment 215747 [details] pushed as 543b740 - import-utils: use TpConnectionManager accessors Attachment 215748 [details] pushed as f39236c - account-settings: use TpConnectionManager accessors Attachment 215749 [details] pushed as 18de9f7 - make empathy_account_settings_get() static
Created attachment 215830 [details] [review] accounts-settings: store parameters as GVariant This patch introduces a GValue leak. I'm going to fix it when switching the rest of this code to GVariant but I prefer to keep patches smaller.
Created attachment 215831 [details] [review] remove empathy_account_settings_set_* functions They don't buy us much so let's just pass the GVariant directly. Fix some string leaks in empathy-account-widget-irc.c as well.
Created attachment 215832 [details] [review] account-settings: always use GVariant to store parameters
Created attachment 215833 [details] [review] empathy_account_settings_migrate_password_cb: use the vardict API
Created attachment 215834 [details] [review] Build with TP_SEAL_ENABLE
Review of attachment 215832 [details] [review]: Why do you dup_string()? you can just use g_variant_get_string(), no?
Attachment 215830 [details] pushed as d51deb6 - accounts-settings: store parameters as GVariant Attachment 215831 [details] pushed as 9d8d7a2 - remove empathy_account_settings_set_* functions Attachment 215832 [details] pushed as 4da4893 - account-settings: always use GVariant to store parameters Attachment 215833 [details] pushed as 9910d4e - empathy_account_settings_migrate_password_cb: use the vardict API Attachment 215834 [details] pushed as 0c54e7a - Build with TP_SEAL_ENABLE