After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677544 - PATCH: camera-device-monitor: Don't add NULL devices to the camera list
PATCH: camera-device-monitor: Don't add NULL devices to the camera list
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
3.4.x
Other Linux
: Normal normal
: 3.6
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
: 671201 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-06-06 09:39 UTC by Hans de Goede
Modified: 2019-12-17 08:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
PATCH: camera-device-monitor: Don't add NULL devices to the camera list (1.33 KB, patch)
2012-06-06 09:39 UTC, Hans de Goede 		committed Details | Review

Description Hans de Goede 2012-06-06 09:39:30 UTC 
Created attachment 215724 [details] [review]
PATCH: camera-device-monitor: Don't add NULL devices to the camera list

cheese_camera_device_monitor_set_up_device() will return NULL for non
video devices (ie vbi & radio devices). Emitting the added signal with
such a NULL device, causes it to get added to the camera list, which later
on causes cheese to crash.

This patch fixes this by not emitting the added signal for non camera devices.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>


Hi,

Note this patch was made against 3.4.2, but it should apply fine to master too.
Also please backport / cherry pick this patch into the 3.4 branch.

Thanks,

Hans
Comment 1 David King 2012-06-06 21:44:32 UTC 
Comment on attachment 215724 [details] [review]
PATCH: camera-device-monitor: Don't add NULL devices to the camera list

Thanks! I pushed a patch with some added comments to gnome-3-4 and master as commits c832acfb1ba296815cb3d38070faedfb1349ebf4 and 60f9af8ff5f14e68588561320530937b1b3e57ed.
Comment 2 Simon McVittie 2019-12-17 08:35:34 UTC 
*** Bug 671201 has been marked as a duplicate of this bug. ***