After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677471 - Annotation color troubles
Annotation color troubles
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: pdf annotations
3.4.x
Other Linux
: Normal enhancement
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 652009 692450 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-06-05 14:22 UTC by João Batista
Modified: 2013-02-02 14:45 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description João Batista 2012-06-05 14:22:05 UTC
The annotation font color (yellow) and the white background of the annotation makes the text very difficult to read. I suggest you keep the annotation overall color scheme but change the text color to black for maximum readability.
Comment 1 Felix Möller 2012-08-03 00:12:45 UTC
agree. The color was black in earlier versions if I am not totally mistaken.
Comment 2 mohican 2012-09-30 19:21:31 UTC
I confirm this bug on Evince 3.4.0 as installed with Ubuntu 12.04 64bits.
Please change status accordingly
Comment 3 Germán Poo-Caamaño 2012-10-01 07:26:20 UTC
(In reply to comment #0)
> The annotation font color (yellow) and the white background of the annotation
> makes the text very difficult to read. I suggest you keep the annotation
> overall color scheme but change the text color to black for maximum
> readability.

This can a problem with the theme.  Evince 3.4.0 in Ubuntu 12.04, and Adwaita,
the note has a light grey background with black foreground when viewing the
comment.  When editing, the background changes to white while the foreground
still is black.

That said, please, try with Adwaita theme.  If you can not reproduce the problem
with Adwaita, then the bug is in the theme.

However, where I see a problem is in the title of the comment (filled with the
author of the comment).
Comment 4 mohican 2012-10-01 11:35:05 UTC
You're right about the color of the comment text :
it's yellow with Ambiance GTK theme, but black with Adwaita.

However as you noted, in both cases the title's text (user's name) is yellow.

Another thing : when I change the color of the note in the preference dialog, it only affects the frame of the annotation (only visible when the annotation is open). The icon of the annotation always stays yellow.
Comment 5 João Batista 2012-10-01 16:29:33 UTC
(In reply to comment #3)
> (In reply to comment #0)
> > The annotation font color (yellow) and the white background of the annotation
> > makes the text very difficult to read. I suggest you keep the annotation
> > overall color scheme but change the text color to black for maximum
> > readability.
> 
> This can a problem with the theme.  Evince 3.4.0 in Ubuntu 12.04, and Adwaita,
> the note has a light grey background with black foreground when viewing the
> comment.  When editing, the background changes to white while the foreground
> still is black.
> 
> That said, please, try with Adwaita theme.  If you can not reproduce the
> problem
> with Adwaita, then the bug is in the theme.
> 
> However, where I see a problem is in the title of the comment (filled with the
> author of the comment).


It's true, I should change the title, any suggestions?

So the problem is in them theme, should I report to the theme owners then?

In my opinion the text should be readable with any theme, wouldn't it be best if it was configurable? Or always in black text over white background to ensure readability?
Comment 6 mohican 2012-10-02 13:44:17 UTC
Well you could change the title of the bug as (may be) :
Annotation color troubles
(because there are several issues here)

Also you should report to the theme owner (so far only 2 themes tested ?)

As for improvements in evince, in the preferences dialog there could be several color adjustments :
- for comment font
- for comment font background
- for title font
- for [title font] background (the one which is now existing) ; this one should work for the annotation icons too
Comment 7 Germán Poo-Caamaño 2013-01-24 18:16:22 UTC
*** Bug 652009 has been marked as a duplicate of this bug. ***
Comment 8 Germán Poo-Caamaño 2013-01-24 18:16:35 UTC
*** Bug 692450 has been marked as a duplicate of this bug. ***
Comment 9 Sebastien Bacher 2013-01-24 18:50:44 UTC
Comment from the bug marked as duplicate:

"Using evince 3.6.1 with any of the Ubuntu theme:
 - open a pdf
 - change the sidebar to annotation
 - select "add"
 - click on the pen icon
 - click somewhere in the pdf
-> you get a note with a yellow border and white background
 - click in it, type some text
-> with adwaita the text is black
-> with light-themes the text is the same yellow as the border, which is not
readable on white

Comments from IRC:

<KaL> the annot window is creating a style properties and changing the color
and bg color, I have no idea why, though, I don't remember :-P
 see libview/ev-annotation-window.c
 in ev_annotation_window_set_color
 in gtk_style_properties_set
 try removing the color and set only the bg color
looks like a bug to me, I don't think we want to set both the fg and bg color
to be the same


I can confirm that dropping the "color" line in that function makes the text
being black the Ubuntu theme and fixes the issue"
Comment 10 Germán Poo-Caamaño 2013-01-25 03:10:22 UTC
(In reply to comment #9)
> [...]
> I can confirm that dropping the "color" line in that function makes the text
> being black the Ubuntu theme and fixes the issue"

In Adwaita the bug seems different.  If you click in the title of annotation window, it gets yellow.  Dropping that line also fixes the issue.
Comment 11 João Batista 2013-01-25 10:30:27 UTC
Title changed as per comment #6 (and it's more fair, the previous looks like it's a complain).
Comment 12 Felix Möller 2013-01-25 20:58:44 UTC
This has been fixed by Ubuntu downstream with the following patch:
diff -Nur evince-3.6.1/libview/ev-annotation-window.c evince-3.6.1.new/libview/ev-annotation-window.c
--- evince-3.6.1/libview/ev-annotation-window.c 2012-06-24 16:30:36.000000000 +0200
+++ evince-3.6.1.new/libview/ev-annotation-window.c     2013-01-25 15:11:08.734467181 +0100
@@ -145,7 +145,6 @@
         properties = gtk_style_properties_new ();
         gtk_style_properties_set (properties, 0,
-                                  "color", &rgba,
                                   "background-color", &rgba,
                                   NULL);
 
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/raring/evince/raring/revision/177

This is not upstreamed to http://git.gnome.org/browse/evince/.
Comment 13 Carlos Garcia Campos 2013-02-02 14:45:24 UTC
Fixed in git master. Thank you all for your help with this issue.