GNOME Bugzilla – Bug 677465
Use TpProtocol more
Last modified: 2012-06-06 09:36:33 UTC
A bunch of tp-glib API have been deprecated. We should stop using them and rely more on TpProtocol.
Created attachment 215715 [details] [review] empathy_account_settings_get_tp_protocol: return a TpProtocol
Created attachment 215716 [details] [review] empathy_account_settings_check_readyness: use the existing TpProtocol to list params No need to request another one.
Created attachment 215717 [details] [review] accounts_widget_generic_setup: continue iterating when treating optional param in simple mode We may have more non-optional parameters later.
Created attachment 215718 [details] [review] account-settings: use TpProtocol's API to get TpConnectionManagerParam
Created attachment 215719 [details] [review] use tp_list_connection_managers_async()
Created attachment 215720 [details] [review] protocol-chooser: use TpProtocol
Created attachment 215721 [details] [review] import-pidgin: use TpProtocol
(In reply to comment #2) > Created an attachment (id=215716) [details] [review] > empathy_account_settings_check_readyness: use the existing TpProtocol to list > params > > No need to request another one. Something looks wrong in indentation in the patch: - if (priv->protocol_obj == NULL) + if (priv->protocol_obj == NULL) wondering if that's mixing tabs and spaces
Review of attachment 215719 [details] [review]: ::: libempathy/empathy-connection-managers.c @@ +254,3 @@ + + g_signal_emit (self, signals[UPDATED], 0); + g_object_unref (self); you should add a tp_weak_ref_destroy() here, no?
The rest looks good
(In reply to comment #8) > (In reply to comment #2) > > Created an attachment (id=215716) [details] [review] [details] [review] > > empathy_account_settings_check_readyness: use the existing TpProtocol to list > > params > > > > No need to request another one. > > Something looks wrong in indentation in the patch: > - if (priv->protocol_obj == NULL) > + if (priv->protocol_obj == NULL) > > wondering if that's mixing tabs and spaces I just miss re-idented when I moved the code around, fixed. (In reply to comment #9) > Review of attachment 215719 [details] [review]: > > ::: libempathy/empathy-connection-managers.c > @@ +254,3 @@ > + > + g_signal_emit (self, signals[UPDATED], 0); > + g_object_unref (self); > > you should add a tp_weak_ref_destroy() here, no? You're right; good catch. Fixed.
Attachment 215715 [details] pushed as ef7ff08 - empathy_account_settings_get_tp_protocol: return a TpProtocol Attachment 215716 [details] pushed as daf7a5b - empathy_account_settings_check_readyness: use the existing TpProtocol to list params Attachment 215717 [details] pushed as c92e84c - accounts_widget_generic_setup: continue iterating when treating optional param in simple mode Attachment 215718 [details] pushed as 505305a - account-settings: use TpProtocol's API to get TpConnectionManagerParam Attachment 215719 [details] pushed as 0e095b8 - use tp_list_connection_managers_async() Attachment 215720 [details] pushed as 899be99 - protocol-chooser: use TpProtocol Attachment 215721 [details] pushed as 3ac6462 - import-pidgin: use TpProtocol