GNOME Bugzilla – Bug 677434
Fix up the shell recorder
Last modified: 2012-09-04 22:21:54 UTC
We have a lot of unused features and cruft in the shell recorder, especially with the filename replacements and removal of pause support. Remove all that junk, and fix up a few errors and issues.
Created attachment 215605 [details] [review] shell-recorder: Don't use a default filename The default filename isn't localized and isn't the same one that the shell sets. Just remove the fallback mechanism, and abort recording if somebody didn't set the filename
Created attachment 215606 [details] [review] shell-recorder: Fix accidental fallthrough Don't append a unique identifier when we asked for a timestamp.
Created attachment 215607 [details] [review] shell-recorder: Remove count and unique filename settigs These aren't used anymore.
Created attachment 215608 [details] [review] shell-recorder: Remove the ability to pause the timeline
Created attachment 215609 [details] [review] shell-recorder: Fix warning message about unknown escapes We were showing the percent character here.
Review of attachment 215605 [details] [review]: Sure
Review of attachment 215606 [details] [review]: Yes.
Review of attachment 215607 [details] [review]: Uhm, I'm not in favor of free code removal usually, but heh, we have git, and it's not we're constantly changing the filename pattern...
Review of attachment 215608 [details] [review]: Ok
Review of attachment 215609 [details] [review]: Sure
Attachment 215605 [details] pushed as f5ca649 - shell-recorder: Don't use a default filename Attachment 215606 [details] pushed as 70d610b - shell-recorder: Fix accidental fallthrough Attachment 215607 [details] pushed as 11ce684 - shell-recorder: Remove count and unique filename settigs Attachment 215608 [details] pushed as f0474ff - shell-recorder: Remove the ability to pause the timeline Attachment 215609 [details] pushed as 14d0a96 - shell-recorder: Fix warning message about unknown escapes