After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677383 - Patch for Evolution-Data-Server API changes
Patch for Evolution-Data-Server API changes
Status: RESOLVED FIXED
Product: ekiga
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ekiga maintainers
Ekiga maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-04 13:09 UTC by Matthew Barnes
Modified: 2012-06-07 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adapt to Evolution-Data-Server API changes (7.20 KB, patch)
2012-06-04 13:09 UTC, Matthew Barnes
none Details | Review

Description Matthew Barnes 2012-06-04 13:09:24 UTC
Created attachment 215542 [details] [review]
Adapt to Evolution-Data-Server API changes

Evolution-Data-Server just landed some major API changes in an effort to get off of GConf and overhaul the way it stores account information.

I blogged about this recently with more details:
http://mbarnes.livejournal.com/4631.html

I'm trying to provide patches to affected modules.  Here's yours.

Note I did not attempt to preserve backward compatibility.  The patch bumps the libebook requirement to >= 3.5.3.
Comment 1 Eugen Dedu 2012-06-07 13:10:19 UTC
On my debian unstable, eds is not yet at the new version.

So do you have a snippet for how to check if we have an old or the new eds?  For ex. a
#define oldversion
or a configure.ac snippet to obtain the eds version?
Comment 2 Eugen Dedu 2012-06-07 14:20:13 UTC
Do not bother.  It is fixed with http://git.gnome.org/browse/ekiga/commit/?id=d84271d7.  Sorry, I forgot to precise your name as commit author.

I see in your patch a comment:

+ /* XXX This blocks. Should it be created asynchronously? */

What to do with it?
Comment 3 Matthew Barnes 2012-06-07 16:56:41 UTC
It blocks while connecting to a D-Bus service.  Whether that's worth fixing is up to you.  I didn't want to change the code more than necessary.
Comment 4 Eugen Dedu 2012-06-07 16:58:58 UTC
Ok, thank you.