After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677313 - Battery icon not updated on state change
Battery icon not updated on state change
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-01 21:50 UTC by Daniel Drake
Modified: 2012-06-06 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.31 KB, patch)
2012-06-01 21:50 UTC, Daniel Drake 		accepted-commit_now Details | Review

Description Daniel Drake 2012-06-01 21:50:25 UTC 
Created attachment 215472 [details] [review]
patch

On OLPC laptops, running GNOME fallback mode with gnome-settings-daemon-3.4.2, the battery status icon that appears in the gnome-panel tray is not updated with new state.

For example, when disconnecting the AC power the icon does not update to the 'battery discharging' icon.

Looks like a missing call to update the status icon after we receive a modified GIcon. Here's a patch to fix it.
Comment 1 Bastien Nocera 2012-06-06 15:17:46 UTC 
Review of attachment 215472 [details] [review]:

Looks correct to push to gnome-3-4 and master
Comment 2 Daniel Drake 2012-06-06 16:36:16 UTC 
Thanks. Pushed as fa834c2 (gnome-3-4) and 99528da (master).