GNOME Bugzilla – Bug 677298
[PATCH] Fix desktop-file-validate icon and category warnings
Last modified: 2012-10-11 13:48:38 UTC
Created attachment 215461 [details] [review] Fix desktop-file-validate icon and category warnings The attached patch fixes the following desktop-file-validate errors/warnings: error: (will be fatal in the future): value "gnome-planner.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path warning: value "GNOME;GTK;Application;Office;ProjectManagement;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application" error: (will be fatal in the future): value "ProjectManagement" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: Office;Development
Hi, (In reply to comment #0) > Created an attachment (id=215461) [details] [review] > Fix desktop-file-validate icon and category warnings Thanks for your contribution. > The attached patch fixes the following desktop-file-validate errors/warnings: I'm curious: did you manually run this tool or is this part of a bigger process? > error: (will be fatal in the future): value "gnome-planner.png" for key "Icon" > in group "Desktop Entry" is an icon name with an extension, but there should be > no extension as described in the Icon Theme Specification if the value is not > an absolute path Ok with that. > warning: value "GNOME;GTK;Application;Office;ProjectManagement;" for key > "Categories" in group "Desktop Entry" contains a deprecated value "Application" Ok. It makes perfect sense: if it has a desktop file, it's an application. > error: (will be fatal in the future): value "ProjectManagement" in key > "Categories" in group "Desktop Entry" requires another category to be present > among the following categories: Office;Development I don't understand this one. We already have the Office category, so we fulfill the requirement. Also Development is not relevant for us, so I don't want to add that.
(In reply to comment #1) > I'm curious: did you manually run this tool or is this part of a bigger > process? Manually on all *.desktop files I had installed. > > error: (will be fatal in the future): value "ProjectManagement" in key > > "Categories" in group "Desktop Entry" requires another category to be present > > among the following categories: Office;Development > > I don't understand this one. We already have the Office category, so we fulfill > the requirement. Also Development is not relevant for us, so I don't want to > add that. I think it's somewhat silly too, but "Office;Development" means that *both* need to be there. If the tool wanted only one of them, it'd say "Office or Development". See also the "Related Categories" explanation and column at http://standards.freedesktop.org/menu-spec/latest/apa.html
(In reply to comment #2) > (In reply to comment #1) > > > error: (will be fatal in the future): value "ProjectManagement" in key > > > "Categories" in group "Desktop Entry" requires another category to be present > > > among the following categories: Office;Development > > > > I don't understand this one. We already have the Office category, so we fulfill > > the requirement. Also Development is not relevant for us, so I don't want to > > add that. > > I think it's somewhat silly too, but "Office;Development" means that *both* > need to be there. If the tool wanted only one of them, it'd say "Office or > Development". See also the "Related Categories" explanation and column at > http://standards.freedesktop.org/menu-spec/latest/apa.html I'd rather we fix this nonsense upstream. I'll send something to the XDG mailing list to discuss this issue, unless you want to take care of it. In the meantime, would it be ok for you if I pushed a first commit with the other fixes?
(In reply to comment #3) > I'd rather we fix this nonsense upstream. I'll send something to the XDG > mailing list to discuss this issue, unless you want to take care of it. Nah, please go ahead. > In the meantime, would it be ok for you if I pushed a first commit with the > other fixes? Sure.
Comment on attachment 215461 [details] [review] Fix desktop-file-validate icon and category warnings I have pushed the approved bits.
http://lists.freedesktop.org/archives/xdg/2012-June/012422.html
I'm too lazy to subscribe to the list, so one more comment here: I think it's odd in general that if one adds category X, one needs to also add category Y - instead having Y there could just imply category X.
That makes sense. I'll voice that opinion later in the discussion (when the list wakes up).
*** Bug 683601 has been marked as a duplicate of this bug. ***
The spec has been fixed, so now we're compliant. http://specifications.freedesktop.org/menu-spec/menu-spec-latest.html#category-registry The validation tool has been fixed as well in http://cgit.freedesktop.org/xdg/desktop-file-utils/commit/?id=7a647466f4455c289549e399b20f86bd50190df3 Closing this bug.