GNOME Bugzilla – Bug 677279
please update to use libmusicbrainz5
Last modified: 2012-08-30 14:09:59 UTC
5 is very similar to 4 (they bumped purely to get around an issue in Debian I believe, where the 4 package name was inexplicably taken by 2 in the distant past…)
[ upstreams bumping major revisions like this because of distro packaging bugs sounds backwards and awful to me but still... ] We just switched to libmusicbrainz4 :( AFAICS libmusicbrainz5 is not packaged in any major distribution yet though.
> We just switched to libmusicbrainz4 :( My sympathies... luckily this is mostly just a sed-job. I actually filed the bug so I'd have something to attach a patch to, and plan to give this a go myself. > AFAICS libmusicbrainz5 is not packaged in any major distribution yet though. That's right. I'm trying to help coordinate it in Debian, it should be uploaded today. Would you like a patch which did 4-or-5 detection, or one that just went straight to 5?
(In reply to comment #2) > > AFAICS libmusicbrainz5 is not packaged in any major distribution yet though. > > That's right. I'm trying to help coordinate it in Debian, it should be uploaded > today. > > Would you like a patch which did 4-or-5 detection, or one that just went > straight to 5? This really depends on the availability of libmusicbrainz5; ideally I would like to hard-depend on v5 in the same way we depend on v4 now, but we can't just do that if it's not available anywhere. I realize this is a bit of a chicken-egg problem, since probably making it a requirement would help distro adoption...if the #ifdef magic needed to support both is not too messy, I would probably go with the former for now.
Created attachment 216267 [details] [review] patch to support mb5 Courtesy of Michael Biebl. I bumped the response limit to 10 to address #677999. This does not do conditional 4-or-5 support.
Review of attachment 216267 [details] [review]: Please send patches against git master.
(In reply to comment #4) > Created an attachment (id=216267) [details] [review] > patch to support mb5 > > Courtesy of Michael Biebl. I bumped the response limit to 10 to address > #677999. Thanks; other than the patch not being against git master, I'd really rather have the 4-or-5 conditional support for now.
Created attachment 216497 [details] [review] mb5 patched rebased against current master > Thanks; other than the patch not being against git master Sorry, I hadn't noticed my checkout aging as much as it has. Patch update against master, but still only 5. > I'd really rather have the 4-or-5 conditional support for now. Sure. My priority at the moment is patching all packages using mb3 or 4 in Debian up to 5… I'm nearly done. After that I'll be looking at things like this. Actually I'm on a train right now and can't easily test mb stuff (no CD-ROM or CDs with me) so I might have a go at this now, it looks pretty straight forward.
*** Bug 683033 has been marked as a duplicate of this bug. ***
Pushed to master now, since musicbrainz5 has been packaged by most distributions.