After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677235 - Clarify the comment at the top of gmarshal.list
Clarify the comment at the top of gmarshal.list
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-05-31 22:52 UTC by Emmanuele Bassi (:ebassi)
Modified: 2012-06-23 21:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update the comment in gmarshal.list (1.19 KB, patch)
2012-05-31 22:53 UTC, Emmanuele Bassi (:ebassi) 		accepted-commit_now Details | Review
Update the comment in gmarshal.list (1.19 KB, patch)
2012-06-23 21:52 UTC, Matthias Clasen 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2012-05-31 22:52:14 UTC 
the current comment makes it look like the code generation for marshallers has been deprecated in favour of g_cclosure_marshal_generic(). this is not the case for projects outside of GLib itself.
Comment 1 Emmanuele Bassi (:ebassi) 2012-05-31 22:53:33 UTC 
Created attachment 215366 [details] [review]
Update the comment in gmarshal.list

The current note makes it look like the marshaller code generation has
been deprecated in favour of the libffi-based generic marshaller; this
is not the case, so we should probably clarify the point a bit.
    
https://bugzilla.gnome.org/show_bug.cgi?id=677235
Comment 2 Colin Walters 2012-05-31 23:29:17 UTC 
Review of attachment 215366 [details] [review]:

This looks slightly better, sure.

(But I think any implementation notes about performance tradeoffs, if you have some, would be better in the gtk-doc for g_cclosure_marshal_generic() )
Comment 3 Matthias Clasen 2012-06-23 21:52:39 UTC 
The following fix has been pushed:
90f7009 Update the comment in gmarshal.list
Comment 4 Matthias Clasen 2012-06-23 21:52:41 UTC 
Created attachment 217098 [details] [review]
Update the comment in gmarshal.list

The current note makes it look like the marshaller code generation has
been deprecated in favour of the libffi-based generic marshaller; this
is not the case, so we should probably clarify the point a bit.