GNOME Bugzilla – Bug 677228
Make Gnome Removable Drive Menu extensions accessible via orca
Last modified: 2012-06-05 17:37:20 UTC
It would be cool if gnome-extensions would better via orca accessible. I Try out this: https://extensions.gnome.org/extension/7/removable-drive-menu/
Please define what is not accessible about it? Or to put it another way, what is Orca failing to do? What steps did you take to reproduce the problem? If the only thing you provide is "doesn't work with Orca", I cannot even redirect the bug to the correct place.
Ok 1.I installed this extension: https://extensions.gnome.org/extension/7/removable-drive-menu/ 2.I Navigate to the panel with the ctrl + alt + tab. 3. I navigate to the Extension with the arrow keys 4. i activate it with the return or space key. 5. i navigate with the arrow keys up and down to see my devices. I expact that orca read the devicenames. but it read only the last entry (open browser or something). I hope it will help :) thx for this great programm :).
That is more helpful thanks! And you are using what version of Orca (orca --version) and what version of gnome-shell (gnome-shell --version)?
Created attachment 215432 [details] [review] Tentative patch I really think that this is a gnome-shell-extensions bug. Looking at the code, it lacks setting the label_actor for that item, as done in other specific PopupBasemenuItem, like in this gnome-shell commit: http://git.gnome.org/browse/gnome-shell/commit/?id=74dd29889121394266322a9f01976a1857b78bb1 This is a tentative patch, that in my opinion should solve that. Having said so, I was not able to test it (so the reason of labelling it as "tentative"). On my jhbuild environment, if I try to use this extension I get this error using this extension: JS LOG: Extension "drive-menu@gnome-shell-extensions.gcampax.github.com" had error: TypeError: this._manager is undefined
As a (likely) gnome-shell-extensions bug, transfering out of Orca.
(In reply to comment #4) > JS LOG: Extension "drive-menu@gnome-shell-extensions.gcampax.github.com" had > error: TypeError: this._manager is undefined It seems that this problem is not about my environment but a real bug, so I have just created bug 677289. Adding a dependency.
Created attachment 215523 [details] [review] Set labels for Removable Drive Menu extension This new patch also adds a name for the menu itself, so Orca could expose it when navigating the top panel. This means a new translatable string. I used "Removable devices" (Note that I didn't use "Removable devices menu", as menu is added due the accessible role).
(In reply to comment #6) > It seems that this problem is not about my environment but a real bug, so I > have just created bug 677289. Adding a dependency. As this bug was solved, I was able to test the extension. I can confirm that patch on comment 7 was tested and worked. I also changed the description of the bug, as this was not a gnome-shell-extensions general problem, but a issue with a specific extension.
Review of attachment 215523 [details] [review]: Looks good, thanks for your patch!
Great work :) thanks for that work!