After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677223 - dshowdecwrapper: Remove dependency to ATL
dshowdecwrapper: Remove dependency to ATL
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-31 19:33 UTC by Raimo Järvi
Modified: 2015-02-05 13:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove dependency to ATL (8.54 KB, patch)
2012-05-31 19:56 UTC, Raimo Järvi 		none Details | Review
Remove dependency on ATL for dshowdecwrapper (8.52 KB, patch)
2014-12-16 03:57 UTC, Matthew Bader 		committed Details | Review

Description Raimo Järvi 2012-05-31 19:33:13 UTC 
dshowdecwrapper doesn't compile with Visual C++ Express, because VC++ Express doesn't include ATL. The following patch removes the dependency to ATL by replacing CComPtr and CComQIPtr with _com_ptr_t.
Comment 1 Raimo Järvi 2012-05-31 19:56:19 UTC 
Created attachment 215363 [details] [review]
Remove dependency to ATL
Comment 2 Marc-Andre Lureau 2012-05-31 20:53:27 UTC 
Nice! Another reason is that ATL uses tons of MSVC proprietary stuff, and is not a free library. So it can't be built with MinGW.
Comment 3 Raimo Järvi 2012-05-31 21:44:28 UTC 
Indeed, although dshowdecwrapper also uses DirectShow Base Classes, so compiling it with MinGW is still not easy.
Comment 4 Andoni Morales 2012-06-01 09:16:23 UTC 
Nice! Even it you still require the Base Classes, I think that it will make it easier to cross-compile the Direct Show plugins with a precompiled version of them.
Comment 5 Tim-Philipp Müller 2014-12-14 21:15:34 UTC 
This needs to be updated to 1.0
Comment 6 Matthew Bader 2014-12-16 03:57:11 UTC 
Created attachment 292786 [details] [review]
Remove dependency on ATL for dshowdecwrapper

Patch updated!
Comment 7 Tim-Philipp Müller 2014-12-16 23:19:59 UTC 
Comment on attachment 292786 [details] [review]
Remove dependency on ATL for dshowdecwrapper

Committed, but kept Raimo as author, since it's really the same patch just with minor updates.