GNOME Bugzilla – Bug 677210
Don't show the message tray background when a banner pops up
Last modified: 2012-07-08 17:56:29 UTC
Currently, the message tray background (the gradient at the bottom of the screen) is displayed when a banner pops up. It would be better not to show the gradient - the background should only be displayed when the tray is properly open. Some mockups: * http://www.youtube.com/watch?v=14z4wdgNF9g * http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/notifications-chat-banner.png
Created attachment 218266 [details] [review] Patch implementing the feature Hi! Here is a proposed patch for the bug.
Review of attachment 218266 [details] [review]: Looks good to me. Committed with small changes to the commit message. Thanks for the patch, Ana!
I don't understand this. How does this relate to the gradient being there or not? Seems we should just have a style class that gets added/removed in banner vs. summary mode that adds the gradient. (Also, there's a style nit with the space after a unary - operator)
Oh, is the idea that there's no longer an entire message tray too, so clicks will by-pass it? If so, yay! Does this mean that simply moving my mouse to the bottom (but not over the notification) will no longer expand the notification? Will it at least keep the notification from timing out?
(In reply to comment #4) > Oh, is the idea that there's no longer an entire message tray too, so clicks > will by-pass it? If so, yay! The gradient won't be displayed when a banner is up, so no - it won't intercept clicks in this case. > Does this mean that simply moving my mouse to the bottom (but not over the > notification) will no longer expand the notification? Will it at least keep the > notification from timing out? For now, placing the pointer on the bottom screen edge over a banner should expand the banner and stop it from disappearing. The longer term plan for this can be found in bug 677217.
This is fantastic, thanks Ana!