GNOME Bugzilla – Bug 677177
Use gtk+ password character in Summary
Last modified: 2016-03-31 13:59:11 UTC
Currently, we're using '*' to hide the password on the Summary page. This does not match the character used by gtk+ for passwords. Use the GtkEntry::invisible_char property as the password character for more consistency.
Created attachment 215317 [details] [review] Use gtk+ password character in Summary
Review of attachment 215317 [details] [review]: I recall that there was a reason I didn't go the gtk way but probably it was because it doesn't match the design mockup so not a a good one. :) ::: src/unattended-installer.vala @@ -23,3 +32,3 @@ owned get { return password_entry.text.length > 0 ? - string.nfill (password_entry.text_length, '*') : _("no password"); + utf8_nfill (password_entry.text_length, password_entry.invisible_char) : _("no password"); Can't you simply convert the unichar to a char somehow so that rest of the code remains the same/simpler?
(In reply to comment #2) > Can't you simply convert the unichar to a char somehow so that rest of the code > remains the same/simpler? You cannot losslessly convert an unichar to a char (sizeof (gunichar2) > sizeof (char)), especially with non-ASCII character as this • character. A char *g_utf8_strnfill(gunichar2) function would be needed if we want to do that more easily, but I've been lazy ;)
Committed with some changes.