GNOME Bugzilla – Bug 677144
network: make sure bridged devices are handled
Last modified: 2013-01-22 14:41:14 UTC
NetworkManager supports bridging nowadays; the network menu should show something reasonable when it meets such a network configuration. (Note: this bug is part of a series of bugs I'm filing for handling 'exotic' network constellations)
See http://fedoraproject.org/wiki/Features/NMEnterpriseNetworking
Created attachment 230659 [details] [review] network: add support for virtual device types (vlan, bond, bridge) Virtual devices may not actually exist until their corresponding connections are brought up. So we need new code to create fake device wrapper objects for them based on the corresponding NMConnections. https://bugzilla.gnome.org/show_bug.cgi?id=677144 https://bugzilla.gnome.org/show_bug.cgi?id=677146 https://bugzilla.gnome.org/show_bug.cgi?id=677148
Created attachment 230660 [details] [review] libnm-gtk: add Bridge support to nm-ui-utils
Created attachment 230661 [details] [review] libnm-gtk: add nma_utils_get_connection_device_name() nma_utils_disambiguate_device_names() can only work for devices that actually exist. Add nma_utils_get_connection_device_name() to get the user-friendly device name for a virtual device that doesn't yet exist.
The libnm-gtk patches are attached mostly just for reference / if you want to try it out. We also still need to deal with the fact that there haven't been NM and nm-applet releases with the new APIs yet. The code here works, so you don't actually need to build everything and test it. I'm not sure this is totally the best way to do everything though... (The issue, as mentioned in the commit message, is that in some cases, the NMDevices for virtual connections won't exist until you actually bring the connection up.)
*** Bug 677146 has been marked as a duplicate of this bug. ***
*** Bug 677148 has been marked as a duplicate of this bug. ***
Review of attachment 230659 [details] [review]: Looks good to me. Ok to commit if tested.
Review of attachment 230660 [details] [review]: This one would be up to you to review really, but it's very straightforward.
Review of attachment 230661 [details] [review]: Makes sense to me.
pushed, along with a separate commit to disable the new functionality under NM 0.9.6, which can be reverted along with the other 0.9.6-compat patch later.
Oh, and if you get errors about NMGtk.utils_get_connection_device_name, update network-manager-applet; the code works with 0.9.6, or with NMGtk as of today, but not with anything in between.