GNOME Bugzilla – Bug 677120
Pinpoint fails to load files if the pinpoint binary is not in the current working directory
Last modified: 2018-08-17 19:57:16 UTC
jeff@krom:~/Documents/présentations/foo bar$ ~/dev/pinpoint/pinpoint baz.pinpoint (pinpoint:3950): Clutter-CRITICAL **: clutter_script_load_from_file: assertion `filename != NULL' failed (same thing happens if I do: /home/jeff/dev/pinpoint/pinpoint \ "/home/jeff/Documents/présentations/foo bar/baz.pinpoint" But not if I do: jeff@krom:~/dev/pinpoint$ ./pinpoint "/home/jeff/Documents/présentations/foo bar/baz.pinpoint"
Created attachment 215280 [details] [review] makes pinpoint look for transitions it its source directory no matter what is the current working directory
I can confirm that the patch solves the issue on my side! Seems pretty trivial too.
Created attachment 215290 [details] [review] better fix this will not leak a hardcoded path in the final binary
I'm not sure you can actually call this a "bug" or "failure". It's just pinpoint not working a your very particular case. Is there really a lot of interest in adding a new script and making the main function a little bit more complicated just for this use case? Where a simple : #!/bin/sh set -e srcdir=$(dirname $0 | xargs readlink -f) cd $srcdir && ./pinpoint would avoid changing the C code.
I think it's better to just assume (and maybe document it somewhere) that when uninstalled, pinpoint will only work when run from its source directory.
Then it needs to be clearly documented on the wiki, README, and ideally pinpoint should throw a more informative error in cases like this instead of the cryptic stuff above that makes you think of a fatal bug. But showing a nice error might be almost as much work as handling paths automatically no? ;)
Review of attachment 215280 [details] [review]: No, this is not acceptable.
Review of attachment 215290 [details] [review]: And neither is this.
You expect something that is not installed to behave like an installed application, which is completely unreasonable to me. Look at how many applications expose their source directory to themselves when uninstalled. Either you install Pinpoint into a system location, or you run it uninstalled from within the source directory.
pinpoint is not under active development anymore since 2015. Its codebase has been archived: https://gitlab.gnome.org/Archive/pinpoint/commits/master Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again.