After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677067 - common needs update to gtk-doc 1.18...
common needs update to gtk-doc 1.18...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: common
git master
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-30 00:44 UTC by Sebastian Rasmussen
Modified: 2012-05-31 11:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch for updating to gtk-doc 1.18. (2.85 KB, patch)
2012-05-30 00:47 UTC, Sebastian Rasmussen
committed Details | Review

Description Sebastian Rasmussen 2012-05-30 00:44:29 UTC
When running gtkdocize for a package using GStreamer
I end with a makefile (fragment) with a check like this:


if ENABLE_GTK_DOC
if GTK_DOC_BUILD_HTML
...
endif
if GTK_DOC_BUILD_PDF
...
endif
endif

When running automake I receive error messages
along the lines of:

GTK_DOC_BUILD_HTML does not appear in AM_CONDITIONAL
GTK_DOC_BUILD_PDF does not appear in AM_CONDITIONAL

After an arduous search through autotools-stuff I 
managed to understand that these ought to be set by
gstreamer/common/m4/gtk-doc.m4.

GStreamer 0.11 depends on glib >= 2.13.14 which in
turn depends on gtk-doc 1.18. If I compare
gtk-doc/gtk-doc.m4 and gstreamer/commer/m4/gtk-doc.m4
they differ. Thus my conclusion is that an update of
gtk-doc.m4 (and any related gtk-doc stuff?) in GStreamer
ought to be done. 

My suggested patch updates gstreamer/common/m4/gtk-doc.m4
to that of gtk-doc 1.18. I retain the check for SED as
has previously been added by GStreamer, moreover I add
a short comment explaining why it is needed to ease future
updates of gtk-doc.m4.

I have successfully build gst-plugins-base and gst-plugins-good
using a common with this patch. I hope this is enough to
prove that this patch is benign.
Comment 1 Sebastian Rasmussen 2012-05-30 00:47:13 UTC
Created attachment 215227 [details] [review]
Proposed patch for updating to gtk-doc 1.18.
Comment 2 Sebastian Dröge (slomo) 2012-05-31 11:07:24 UTC
commit f1b5a966f3cf50fbbc4a2f02a1a3b64b9668e375
Author: Sebastian Rasmussen <sebrn@axis.com>
Date:   Wed May 30 02:00:02 2012 +0200

    m4: Update gtk-doc m4 macros to those of gtk-doc 1.18