After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677031 - gnome-rr: Add gnome_rr_output_get_ids_for_edid()
gnome-rr: Add gnome_rr_output_get_ids_for_edid()
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks: 677032
 
 
Reported: 2012-05-29 14:18 UTC by Bastien Nocera
Modified: 2012-06-14 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-rr: Add gnome_rr_output_get_ids_for_edid() (2.76 KB, patch)
2012-05-29 14:18 UTC, Bastien Nocera
none Details | Review
gnome-rr: Add gnome_rr_output_get_ids_from_edid() (2.78 KB, patch)
2012-06-14 15:25 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2012-05-29 14:18:09 UTC
.
Comment 1 Bastien Nocera 2012-05-29 14:18:10 UTC
Created attachment 215180 [details] [review]
gnome-rr: Add gnome_rr_output_get_ids_for_edid()

To get the vendor/product/serial triplet from an output.
This is useful for output matching in gnome-settings-daemon.
Comment 2 Federico Mena Quintero 2012-05-29 18:52:41 UTC
Interesting.  How do you plan to use this from g-s-d?

(Is the vendor null-terminated, or should we allocate a 5-byte string and terminate it ourselves, for safety?)
Comment 3 Bastien Nocera 2012-05-30 10:30:48 UTC
(In reply to comment #2)
> Interesting.  How do you plan to use this from g-s-d?

See the patch in bug 677032

> (Is the vendor null-terminated, or should we allocate a 5-byte string and
> terminate it ourselves, for safety?)

it's 3 letters, and it's null-terminated in decode_vendor_and_product_identification():
 63     info->manufacturer_code[3]  = '\0';
Comment 4 Federico Mena Quintero 2012-06-05 17:39:44 UTC
Oh, I see, you want to look at the "WAC" vendor.  Makes sense; go ahead with the change.
Comment 5 Bastien Nocera 2012-06-14 15:25:15 UTC
Created attachment 216422 [details] [review]
gnome-rr: Add gnome_rr_output_get_ids_from_edid()

To get the vendor/product/serial triplet from an output's EDID data.
This is useful for output matching in gnome-settings-daemon.
Comment 6 Bastien Nocera 2012-06-14 15:26:00 UTC
Attachment 216422 [details] pushed as db122d9 - gnome-rr: Add gnome_rr_output_get_ids_from_edid()