After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677003 - Finish migrating help to modern yelp-tools build system
Finish migrating help to modern yelp-tools build system
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: docs
unspecified
Other All
: Normal normal
: ---
Assigned To: Maintainers of Gnome user documentation
GNOME Terminal Maintainers
Depends on:
Blocks: 681609
 
 
Reported: 2012-05-29 00:55 UTC by Jeremy Bicha
Modified: 2013-07-21 17:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Finish migrating help to modern yelp-tools build system (3.04 KB, patch)
2012-05-29 00:55 UTC, Jeremy Bicha
none Details | Review
Finish migrating help to modern yelp-tools build system (2.99 KB, patch)
2012-06-02 18:56 UTC, Jeremy Bicha
none Details | Review
rm old help translations (bg ro ja zh_TW) that haven't been touched for years (384.41 KB, patch)
2012-06-02 19:02 UTC, Jeremy Bicha
none Details | Review

Description Jeremy Bicha 2012-05-29 00:55:29 UTC
I apologize for not actually having tested this yet, since Ubuntu's
development release doesn't have GTK+ 3.5.3 yet, but I believe this
patch is correct.
Comment 1 Jeremy Bicha 2012-05-29 00:55:32 UTC
Created attachment 215159 [details] [review]
Finish migrating help to modern yelp-tools build system

This was started with
http://git.gnome.org/browse/gnome-terminal/commit/src/terminal-util.c?id=040fcff03b

gnome-terminal will now need to build-depend on yelp-tools instead of
gnome-doc-utils. Help will be stored in /usr/share/help/ instead of
/usr/share/gnome/help/
Comment 2 Christian Persch 2012-05-29 11:34:23 UTC
A few things:

+#	figures/terminal-window.png   This image is not used.

If that's true, just git rm the file and remove this line.

+HELP_LINGUAS = da de ca cs el en_GB es fr gl it ko oc pt_BR ru sl sv te uk zh_CN

Should be sorted alphabetically.

-# Move to DOC_LINGUAS in transition to gnome-doc-utils
-
-SUBDIRS = bg ro ja zh_TW

So I think the time has come to just git rm -r these obsolete translations that don't even use g-d-u yet.

+HELP_FILES = \
+	index.docbook \
+	legal.xml

Declare "NULL =" (empty) at the top, and add a $(NULL) line here at the end of HELP_FILES.
Comment 3 Jeremy Bicha 2012-06-02 18:56:32 UTC
Created attachment 215499 [details] [review]
Finish migrating help to modern yelp-tools build system

This was started with
http://git.gnome.org/browse/gnome-terminal/commit/src/terminal-util.c?id=040fcff03b

gnome-terminal will now need to build-depend on yelp-tools instead of
gnome-doc-utils. Help will be stored in /usr/share/help/ instead of
/usr/share/gnome/help/
Comment 4 Jeremy Bicha 2012-06-02 19:02:55 UTC
Created attachment 215500 [details] [review]
rm old help translations (bg ro ja zh_TW) that haven't been touched for years
Comment 5 Jeremy Bicha 2012-06-02 19:06:14 UTC
Christian, what's the point of your extra NULL lines? They aren't necessary.
Comment 6 Christian Persch 2012-06-04 22:50:44 UTC
Just a way to keep 'git blame' clean.

I fixed the commits up a bit and pushed to master. Thanks!