Created attachment 215121 [details] [review]
text: Enable implicit color animations

Created attachment 215122 [details] [review]
text: Enable implicit color animations

Implement the ClutterAnimatable interface to enable implicit animations
for :color, :cursor-color, :selected-text-color and :selection-color.

Review of attachment 215122 [details] [review]:

looks generally okay to me; a couple of minor issues.

::: clutter/clutter-text.c
@@ +2983,3 @@
+  const gchar *name;
+
+      other = obj_props[PROP_SELECTION_COLOR_SET];

there's no need to use g_return_* inside internal functions.

@@ +2988,3 @@
+  priv = self->priv;
+
+    case PROP_SELECTED_TEXT_COLOR:

instead of casting to ClutterActor multiple times, you could use a variable to hold the actor pointer.

also, you can use _clutter_actor_get_animation_info_or_default(), given that you're not modifying the ClutterAnimationInfo structure, but only reading from it.

@@ +2989,3 @@
+
+  info = _clutter_actor_get_animation_info (CLUTTER_ACTOR (self));
+    case PROP_SELECTED_TEXT_COLOR:

pspec->name is perfectly fine - no need to use g_param_spec_get_name().

Created attachment 215123 [details] [review]
text: Enable implicit color animations

Implement the ClutterAnimatable interface to enable implicit animations
for :color, :cursor-color, :selected-text-color and :selection-color.

Review of attachment 215123 [details] [review]:

looks good

Attachment 215123 [details] pushed as 58b13aa - text: Enable implicit color animations