After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676959 - Custom shapes don't support svg:text
Custom shapes don't support svg:text
Status: RESOLVED FIXED
Product: dia
Classification: Other
Component: objects
CVS head
Other Linux
: Normal normal
: 0.98
Assigned To: Dia maintainers
Dia maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-28 10:32 UTC by Steffen Macke
Modified: 2012-06-23 12:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Initial patch to handle font-size attribute (3.13 KB, patch)
2012-05-31 19:45 UTC, Hans Breuer 		none Details | Review

Description Steffen Macke 2012-05-28 10:32:08 UTC 
There's code to support svg:text in the custom shapes module and it's also advertised in doc/custom-shapes. But Dia won't render the text. Shape from

https://mail.gnome.org/archives/dia-list/2012-May/msg00031.html

can be used as an example.

I'm not sure if additional text-related style controls should be added to the object properties dialog in this case.
Comment 1 Hans Breuer 2012-05-31 19:45:54 UTC 
Created attachment 215362 [details] [review]
Initial patch to handle font-size attribute

The fix for bug 665648 unfortunately caused an incompatibility between SVG/Shape export and the respective Dia internal SVG importers. The svg:text font-size had to be split into it's own attribute, but the custom shape reader as well as the SVG import still expect the information to be within the style attribute.

The patch needs some more testing - maybe even auomated ones - before it should go in.
Comment 2 Hans Breuer 2012-06-23 12:38:53 UTC 
Committed the patch after adding a rough check with the updated dtd.
http://git.gnome.org/browse/dia/commit/?id=f4e3e611a409b1fac19b6e1bc74b4823f205d37f