After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676954 - The filled in boxes have a too dark gray background
The filled in boxes have a too dark gray background
Status: RESOLVED FIXED
Product: gnome-sudoku
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-sudoku-maint
gnome-sudoku-maint
: 676955 676956 (view as bug list)
Depends on:
Blocks: 710626
 
 
Reported: 2012-05-28 09:45 UTC by Antonio Ospite
Modified: 2014-07-04 09:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
new shade (25.28 KB, image/png)
2013-11-07 17:06 UTC, Michael Catanzaro
  Details
Lighten the color of completed squares (892 bytes, patch)
2014-06-03 02:51 UTC, Michael Catanzaro
committed Details | Review
OLD python - Lighten the color of completed squares (615 bytes, patch)
2014-07-03 11:18 UTC, Antonio Ospite
none Details | Review
screenshot of current version (20.92 KB, image/png)
2014-07-03 15:28 UTC, Michael Catanzaro
  Details

Description Antonio Ospite 2012-05-28 09:45:06 UTC
Hi,

when I start a new puzzle having the "initially filled in boxes" highlighted someway may make sense, but when we go into the game a filled in box is just that regardless than it was an _initially_ filled in box of if I filled it in myself, having that gray (or grey) background can be distracting.

In old version the difference was more subtle, "initially filled in boxes" just used a bold font, consider reverting to that please or just don't make any difference at all :)

Thanks,
   Antonio
Comment 1 André Klapper 2012-05-28 10:28:45 UTC
*** Bug 676955 has been marked as a duplicate of this bug. ***
Comment 2 André Klapper 2012-05-28 10:28:48 UTC
*** Bug 676956 has been marked as a duplicate of this bug. ***
Comment 3 Antonio Ospite 2012-05-28 11:23:42 UTC
Sorry for the duplicate entries, a lagged connection and a couple of mouse clicks too much.

When I say "don't make any difference at all", I mean I would find acceptable even if all the boxes had always the same style. However some style differentiation make sense indeed if we think to the paper sudoku where the numbers we fill in by hand are visually different from the ones printed initially.
Comment 4 Michael Catanzaro 2013-11-07 17:06:21 UTC
Created attachment 259203 [details]
new shade
Comment 5 Michael Catanzaro 2013-11-07 17:07:02 UTC
They're a lighter shade of gray in the Vala port.  Perhaps they could be lighter still.
Comment 6 Antonio Ospite 2013-11-07 18:50:39 UTC
Thanks for looking into it Michael.

Again, what about just using a bold style? Mayb with a dark gray color for the text but on a white background: to communicate to the user "you cannot change these boxes".

The gray background is a bit distracting IMHO.

Ciao,
   Antonio
Comment 7 Michael Catanzaro 2013-11-07 19:22:26 UTC
I don't really have a preference either way. We've got a new design at Bug #710626 that calls for "lightening the colour of completed squares" but I believe that means changing the background from white to light gray when a number is selected. It doesn't really touch on the distinction between pre-filled and user-filled squares. Allan, could you provide guidance?
Comment 8 Michael Catanzaro 2014-06-03 02:51:26 UTC
The following fix has been pushed:
5222b5c Lighten the color of completed squares
Comment 9 Michael Catanzaro 2014-06-03 02:51:30 UTC
Created attachment 277776 [details] [review]
Lighten the color of completed squares

https://bugzilla.gnome.org/show_bug.cgi?id=676954
https://bugzilla.gnome.org/show_bug.cgi?id=710626
Comment 10 Antonio Ospite 2014-07-03 11:18:30 UTC
Created attachment 279832 [details] [review]
OLD python - Lighten the color of completed squares

Thanks for fixing that.

Just for reference I attach a patch I have been using for the old python version of gnome-sudoku.
Comment 11 Michael Catanzaro 2014-07-03 15:28:44 UTC
Created attachment 279847 [details]
screenshot of current version

OK, but you're aware there isn't going to be a new Python release. :)

Ah, as a heads-up, we ended up reverting this so that we could lighten the colors of all squares in the current row/column instead. Here is what it looks like now.
Comment 12 Antonio Ospite 2014-07-04 09:15:12 UTC
I know, I know about the pyhton code, I just had the patch locally and I thought I'd share it.

About the screenshot, I don't quite understand the black box, but if I concentrate (it's _very_ subtle) I can see the gray crosshair.

The pre-filled boxes are still a little too dark IMHO, maybe we can just mark them with a white background and gray _text_, to communicate that they are _inactive_?

Thanks,
   Antonio
Comment 13 Parin Porecha 2014-07-04 09:21:10 UTC
> About the screenshot, I don't quite understand the black box, but if I
> concentrate (it's _very_ subtle) I can see the gray crosshair.

The black box is a bug (https://bugzilla.gnome.org/show_bug.cgi?id=710626#c2)