GNOME Bugzilla – Bug 676914
Provide menu item for private browsing
Last modified: 2012-12-12 11:41:42 UTC
Private browsing should be accessible without the user having to lookup and type the "epiphany -p" command. A menu item should be sufficient.
Created attachment 215385 [details] [review] ephy-shell: add "New private window" Proof of concept for a menu item for our long neglected feature.
*** Bug 145386 has been marked as a duplicate of this bug. ***
(In reply to comment #1) > Created an attachment (id=215385) [details] [review] > ephy-shell: add "New private window" > > Proof of concept for a menu item for our long neglected feature. Yeah, we are not going to do it like that ;) A few things: - This will be different (and easier) with WebKit2. We are actively working on that, so let's wait for it. It seems we could actually have it working in Beta status for 3.6. - Once we can sanely have different webkit processes in the same ephy this is just a matter of doing enough refactoring for each of them to use a different profile. It should not be very difficult to do, and we can start working on it right now even. Just do all the bits needed assuming it will be possible for this to work in the future.
(In reply to comment #3) > (In reply to comment #1) > > Created an attachment (id=215385) [details] [review] [details] [review] > > ephy-shell: add "New private window" > > > > Proof of concept for a menu item for our long neglected feature. > > Yeah, we are not going to do it like that ;) > > A few things: > > - This will be different (and easier) with WebKit2. We are actively working on > that, so let's wait for it. It seems we could actually have it working in Beta > status for 3.6. Sure! No problem. Let's see how we can make that work for 3.6. I will look into some refactoring for easier profile switching. Let's see what can I find.
Created attachment 231333 [details] [review] incognito.diff OK, turns out people want the incognito thing to be in a completely different process, so in the end we'll basically have to do something like launching a -p instance from the UI. Add an 'incognito mode' that does that, plus stealing history/bookmarks from the main profile in read-only mode, and add the proper hooks to launch it. Follow up patch will make a nice startup page for it, since it makes a lot more sense than the overview.
Review of attachment 231333 [details] [review]: Looks edible. However, I think we need to freeze even the history copy of the history we are using so that whatever website you're visiting in this incognito mode doesn't even show up in the history while the incognito session is active.
Review of attachment 231333 [details] [review]: Looks good. Do we want to add ctrl+shift+N as shortcut? That's chrome's shortcut. (Iceweasel has no shortcut I know of) ::: src/window-commands.h @@ +114,3 @@ + EphyWindow *window); +void window_cmd_edit_personal_data (GtkAction *action, + EphyWindow *window); All the indentation you can eat, 5.99.
(In reply to comment #7) > Review of attachment 231333 [details] [review]: > > Looks good. Do we want to add ctrl+shift+N as shortcut? That's chrome's > shortcut. (Iceweasel has no shortcut I know of) The patch already adds the shortcut, no? > > ::: src/window-commands.h > @@ +114,3 @@ > + EphyWindow *window); > +void window_cmd_edit_personal_data (GtkAction *action, > + EphyWindow *window); > > All the indentation you can eat, 5.99. Estamos que lo regalamos.