After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676905 - ephy-shell: small cleanups
ephy-shell: small cleanups
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-26 22:37 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-06-14 23:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ephy-shell: fix braces (1.45 KB, patch)
2012-05-26 22:37 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review
ephy-shell: handy gboolean fullscreen_lockdown (1.38 KB, patch)
2012-05-26 22:37 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review
ephy-shell: imitate other flag checks for jump_to (1.30 KB, patch)
2012-05-26 22:37 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-05-26 22:37:31 UTC 
Some cleanups of code style I found while working on a test for shell.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-05-26 22:37:33 UTC 
Created attachment 215076 [details] [review]
ephy-shell: fix braces
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2012-05-26 22:37:36 UTC 
Created attachment 215077 [details] [review]
ephy-shell: handy gboolean fullscreen_lockdown
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-05-26 22:37:40 UTC 
Created attachment 215078 [details] [review]
ephy-shell: imitate other flag checks for jump_to
Comment 4 Xan Lopez 2012-06-13 17:07:24 UTC 
Review of attachment 215076 [details] [review]:

OK.
Comment 5 Xan Lopez 2012-06-13 17:09:57 UTC 
Review of attachment 215077 [details] [review]:

OK.
Comment 6 Xan Lopez 2012-06-13 17:10:06 UTC 
Review of attachment 215078 [details] [review]:

OK.
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2012-06-14 23:24:21 UTC 
Attachment 215076 [details] pushed as 5abbb83 - ephy-shell: fix braces
Attachment 215077 [details] pushed as e32345a - ephy-shell: handy gboolean fullscreen_lockdown
Attachment 215078 [details] pushed as ccf3836 - ephy-shell: imitate other flag checks for jump_to