After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676851 - build failure: totem-plugin-viewer.c:56:21: fatal error: marshal.h: No such file or directory
build failure: totem-plugin-viewer.c:56:21: fatal error: marshal.h: No such f...
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-05-25 22:42 UTC by Craig Keogh
Modified: 2012-05-28 11:56 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Craig Keogh 2012-05-25 22:42:51 UTC
I am building totem git master via JHBuild on Fedora 16. D-BUS Binding Tool version 0.94 (dbus version 1.4.0). The build fails with:

/opt/gnome/bin/dbus-binding-tool --prefix=totem_embedded --mode=glib-server org_gnome_totem_PluginViewer.xml > totem-plugin-viewer-interface.h
gcc -DHAVE_CONFIG_H -I. -I..  -DGNOMELOCALEDIR="\"/opt/gnome/share/locale\"" -DG_LOG_DOMAIN=\""TotemEmbedded\"" -I.. -I../src -I../src/backend -I../src -I../src/backend -DSYSCONFDIR="\"/opt/gnome/etc\"" -DLIBEXECDIR="\"/opt/gnome/libexec\"" -DGCONF_DISABLE_DEPRECATED -DGCONF_DISABLE_SINGLE_INCLUDES -DBONOBO_DISABLE_DEPRECATED -DBONOBO_DISABLE_SINGLE_INCLUDES -DBONOBO_UI_DISABLE_DEPRECATED -DBONOBO_UI_DISABLE_SINGLE_INCLUDES -DGNOME_DISABLE_DEPRECATED -DGNOME_DISABLE_SINGLE_INCLUDES -DLIBGLADE_DISABLE_DEPRECATED -DLIBGLADE_DISABLE_SINGLE_INCLUDES -DGNOME_VFS_DISABLE_DEPRECATED -DGNOME_VFS_DISABLE_SINGLE_INCLUDES -DWNCK_DISABLE_DEPRECATED -DWNCK_DISABLE_SINGLE_INCLUDES -DLIBSOUP_DISABLE_DEPRECATED -DLIBSOUP_DISABLE_SINGLE_INCLUDES  -pthread -D_LARGEFILE64_SOURCE -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib64/glib-2.0/include -I/opt/gnome/include/gtk-3.0 -I/opt/gnome/include/pango-1.0 -I/opt/gnome/include/gio-unix-2.0/ -I/opt/gnome/include/atk-1.0 -I/opt/gnome/include/cairo -I/opt/gnome/include/gdk-pixbuf-2.0 -I/opt/gnome/include/totem-pl-parser/1/plparser -I/opt/gnome/include/libxml2 -I/opt/gnome/include/gmime-2.6 -I/opt/gnome/include/gstreamer-0.10 -I/opt/gnome/include/clutter-gtk-1.0 -I/opt/gnome/include/clutter-1.0 -I/opt/gnome/include/cogl -I/opt/gnome/include/json-glib-1.0 -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/libdrm   -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare  -I/opt/gnome/include/dbus-1.0 -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib64/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include     -Wall 	-Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes 	-Wnested-externs -Wpointer-arith 	-Wcast-align -Wsign-compare 	-fno-strict-aliasing 	 -O0 -g -MT totem_plugin_viewer-totem-plugin-viewer.o -MD -MP -MF .deps/totem_plugin_viewer-totem-plugin-viewer.Tpo -c -o totem_plugin_viewer-totem-plugin-viewer.o `test -f 'totem-plugin-viewer.c' || echo './'`totem-plugin-viewer.c
totem-plugin-viewer.c:56:21: fatal error: marshal.h: No such file or directory
compilation terminated.
make[2]: *** [totem_plugin_viewer-totem-plugin-viewer.o] Error 1
make[2]: Leaving directory `/home/oxyde/gnome/build/totem/browser-plugin'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/oxyde/gnome/build/totem'
make: *** [all] Error 2
*** Error during phase build of totem: ########## Error running make  -j 1 V=1 *** [1/1]
Comment 1 Philip Withnall 2012-05-27 20:56:53 UTC
I can’t reproduce this with `make maintainer-clean; autogen.sh --options; make`. Does moving the “$(MARSHAL_FILES)” line from the bottom to the top of “totem_plugin_viewer_SOURCES” in browser-plugin/Makefile.am fix it?
Comment 2 Philip Withnall 2012-05-27 20:57:57 UTC
(In reply to comment #1)
> I can’t reproduce this with `make maintainer-clean; autogen.sh --options;
> make`. Does moving the “$(MARSHAL_FILES)” line from the bottom to the top of
> “totem_plugin_viewer_SOURCES” in browser-plugin/Makefile.am fix it?

Alternatively, what about removing the following line?
    totem-plugin-viewer.c: totem-plugin-viewer-interface.h
IIRC, that might override automake’s default dependency list for totem-plugin-viewer.c, and thus stop marshal.c being built beforehand.
Comment 3 Craig Keogh 2012-05-28 11:21:49 UTC
(In reply to comment #1)
> make`. Does moving the “$(MARSHAL_FILES)” line from the bottom to the top of
> “totem_plugin_viewer_SOURCES” in browser-plugin/Makefile.am fix it?

(In reply to comment #2)
> Alternatively, what about removing the following line?
>     totem-plugin-viewer.c: totem-plugin-viewer-interface.h

No, sorry. I tried both methods. Both didn't work. I did a full 'rm -rf' & 'git reset --hard' before each attempt.

The following did work (I can upload a proper format-patch if you like):

diff --git a/browser-plugin/Makefile.am b/browser-plugin/Makefile.am
index 2ba8167..831448c 100644
--- a/browser-plugin/Makefile.am
+++ b/browser-plugin/Makefile.am
@@ -81,7 +81,7 @@ test_glow_button_CFLAGS = \
 libexec_PROGRAMS = totem-plugin-viewer
 
 # Are we a bit thick, Mister?
-totem-plugin-viewer.c: totem-plugin-viewer-interface.h
+totem-plugin-viewer.c: totem-plugin-viewer-interface.h $(MARSHAL_FILES)
 
 totem_plugin_viewer_SOURCES = \
        totem-glow-button.c             \
Comment 4 Bastien Nocera 2012-05-28 11:56:31 UTC
commit 199717f0da40602f04b1c742e30d78b8168c02d9
Author: Craig Keogh <cskeogh@adam.com.au>
Date:   Mon May 28 12:55:25 2012 +0100

    browser-plugin: Fix parallel build
    
    By making totem-plugin-viewer.c require the marshal files to
    be generated.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=676851