After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676843 - Fix various memory leaks
Fix various memory leaks
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-25 20:36 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-05-25 20:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix various memory leaks (3.67 KB, patch)
2012-05-25 20:36 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-05-25 20:36:14 UTC
See patch.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-05-25 20:36:16 UTC
Created attachment 215004 [details] [review]
Fix various memory leaks

Found with make valgrind-check. We should run it more often.
Comment 2 Colin Walters 2012-05-25 20:44:52 UTC
Review of attachment 215004 [details] [review]:

We leak in some error paths still, but let's just go with this, better to incrementally improve rather than trying to fix everything at once.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-05-25 20:50:52 UTC
Attachment 215004 [details] pushed as 48c9795 - Fix various memory leaks