After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676803 - Default Context Manager depends on target OS
Default Context Manager depends on target OS
Status: RESOLVED FIXED
Product: GUPnP
Classification: Other
Component: gupnp
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-05-25 08:59 UTC by Ludovic Ferrandis
Modified: 2012-08-19 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Defaut CM - Cover Letter - v0 (625 bytes, patch)
2012-05-25 08:59 UTC, Ludovic Ferrandis 		none Details | Review
Defaut CM - Default CM - v0 (1.20 KB, patch)
2012-05-25 09:00 UTC, Ludovic Ferrandis 		committed Details | Review
Defaut CM - Coding Style - v0 (791 bytes, patch)
2012-05-25 09:00 UTC, Ludovic Ferrandis 		needs-work Details | Review
Defaut CM - Coding Style - v1 (783 bytes, patch)
2012-07-02 11:34 UTC, Ludovic Ferrandis 		none Details | Review
Defaut CM - Coding Style - v1 (812 bytes, patch)
2012-07-02 12:46 UTC, Ludovic Ferrandis 		accepted-commit_now Details | Review
Defaut CM - Coding Style - v2 (793 bytes, patch)
2012-07-02 14:40 UTC, Ludovic Ferrandis 		committed Details | Review

Description Ludovic Ferrandis 2012-05-25 08:59:20 UTC 
Created attachment 214918 [details] [review]
Defaut CM - Cover Letter - v0

On Linux OS, default context manager is 'linux.
On other OS, default context manager is 'unix'
Comment 1 Ludovic Ferrandis 2012-05-25 09:00:09 UTC 
Created attachment 214919 [details] [review]
Defaut CM - Default CM - v0
Comment 2 Ludovic Ferrandis 2012-05-25 09:00:42 UTC 
Created attachment 214920 [details] [review]
Defaut CM - Coding Style - v0
Comment 3 Jens Georg 2012-07-01 09:28:54 UTC 
Review of attachment 214920 [details] [review]:

That should probably be converted to AS_HELP_STRING anyway
Comment 4 Jens Georg 2012-07-01 09:29:24 UTC 
Review of attachment 214919 [details] [review]:

Looks good
Comment 5 Ludovic Ferrandis 2012-07-02 11:34:12 UTC 
Created attachment 217822 [details] [review]
Defaut CM - Coding Style - v1

Add AS_HELP_STRING

Rebase on b5a1c69
Comment 6 Ludovic Ferrandis 2012-07-02 12:46:45 UTC 
Created attachment 217827 [details] [review]
Defaut CM - Coding Style - v1

oops. Upload wrong version of the patch. This is the good one.
Comment 7 Zeeshan Ali 2012-07-02 14:33:04 UTC 
Review of attachment 217827 [details] [review]:

Looks good. 'Tab->Space' is now a detail that could be ignored so just write "Make use of AS_HELP_STRING" in the log.
Comment 8 Ludovic Ferrandis 2012-07-02 14:40:15 UTC 
Created attachment 217839 [details] [review]
Defaut CM - Coding Style - v2

Change commit string
Comment 9 Zeeshan Ali 2012-07-02 14:42:22 UTC 
Review of attachment 217839 [details] [review]:

ACK. I'm assuming you tested it. :)