After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676787 - Update printing demo to use new print setting
Update printing demo to use new print setting
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-05-25 03:01 UTC by Timothy Arceri
Modified: 2012-08-25 21:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use new printer setting to reduce code required (4.14 KB, patch)
2012-05-25 03:06 UTC, Timothy Arceri
none Details | Review
Use new printer setting to reduce code required (1.81 KB, patch)
2012-05-25 03:09 UTC, Timothy Arceri
none Details | Review
Use new printer setting to reduce code required (2.05 KB, patch)
2012-05-25 03:15 UTC, Timothy Arceri
accepted-commit_now Details | Review
Use new printer setting to reduce code required (1.96 KB, patch)
2012-08-25 13:35 UTC, Timothy Arceri
accepted-commit_now Details | Review
Use new printer setting to reduce code required by application (1.97 KB, patch)
2012-08-25 21:48 UTC, Matthias Clasen
committed Details | Review

Description Timothy Arceri 2012-05-25 03:01:20 UTC
A new print setting has been added to reduce the amount of code needed in an application when changing the default filename in the print to file dialog.

The printing demo should be updated to show the use of this new setting.
Comment 1 Timothy Arceri 2012-05-25 03:06:53 UTC
Created attachment 214910 [details] [review]
Use new printer setting to reduce code required
Comment 2 Timothy Arceri 2012-05-25 03:09:43 UTC
Created attachment 214911 [details] [review]
Use new printer setting to reduce code required

Uploading the right patch this time. Whoops.
Comment 3 Timothy Arceri 2012-05-25 03:15:23 UTC
Created attachment 214912 [details] [review]
Use new printer setting to reduce code required

Updated patch to remove unused variables
Comment 4 Sebastian 2012-08-22 12:18:54 UTC
Review of attachment 214912 [details] [review]:

Thats perfekt.
Comment 5 Colomban Wendling 2012-08-22 16:41:42 UTC
The patch changes the file mode from 644 to 755 which is probably not wanted, should be fixed before committing.
Comment 6 Matthias Clasen 2012-08-22 23:05:35 UTC
Review of attachment 214912 [details] [review]:

Code changes look fine. Just don't change the file mode, as was already pointed out.
Comment 7 Timothy Arceri 2012-08-25 13:35:11 UTC
Created attachment 222396 [details] [review]
Use new printer setting to reduce code required

Removed the permission changes. Can someone push the changes?
Comment 8 Colomban Wendling 2012-08-25 13:40:31 UTC
Review of attachment 222396 [details] [review]:

Looks good now (at least it's the exact same than the previously accepted one, but without the mode change)
Comment 9 Matthias Clasen 2012-08-25 21:48:31 UTC
The following fix has been pushed:
2ab8e75 Use new printer setting to reduce code required by application
Comment 10 Matthias Clasen 2012-08-25 21:48:34 UTC
Created attachment 222437 [details] [review]
Use new printer setting to reduce code required by application

Updated demo to use new setting that allows an application to change the
output filename without the need to create the uri itself.