After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676669 - don't offer multi select when there is nothing to select
don't offer multi select when there is nothing to select
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-05-23 17:11 UTC by William Jon McCann
Modified: 2016-03-31 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (7.45 KB, image/png)
2012-05-23 17:11 UTC, William Jon McCann 		  Details
Insensitive selection button on empty collection (1.42 KB, patch)
2012-06-06 00:51 UTC, Zeeshan Ali 		reviewed Details | Review
Insensitive selection button on empty collection (1.41 KB, patch)
2012-06-06 13:45 UTC, Zeeshan Ali 		committed Details | Review

Description William Jon McCann 2012-05-23 17:11:39 UTC 
Created attachment 214795 [details]
screenshot

Don't offer multi select when there is nothing to select.
Comment 1 Zeeshan Ali 2012-06-06 00:51:54 UTC 
Created attachment 215700 [details] [review]
Insensitive selection button on empty collection

Selection button should be insensitive when collection is empty.
Comment 2 Christophe Fergeau 2012-06-06 08:30:33 UTC 
Shouldn't we go back to displaying the wizard when this happens? This is related to https://bugzilla.gnome.org/show_bug.cgi?id=674657
Comment 3 Marc-Andre Lureau 2012-06-06 09:37:54 UTC 
(In reply to comment #2)
> Shouldn't we go back to displaying the wizard when this happens? This is
> related to https://bugzilla.gnome.org/show_bug.cgi?id=674657

Only during startup, I think.
Comment 4 Marc-Andre Lureau 2012-06-06 09:40:17 UTC 
Review of attachment 215700 [details] [review]:

::: src/topbar.vala
@@ +153,3 @@
     }
 
+    private void update_selection_btn_sensitivity () {

It would make sense to keep same prefix as the widget name.

select_btn => update_select_btn
Comment 5 Zeeshan Ali 2012-06-06 13:45:25 UTC 
Created attachment 215751 [details] [review]
Insensitive selection button on empty collection
Comment 6 Marc-Andre Lureau 2012-06-06 14:14:12 UTC 
Review of attachment 215751 [details] [review]:

ack
Comment 7 Zeeshan Ali 2012-06-06 14:30:42 UTC 
Attachment 215751 [details] pushed as 18c0c0f - Insensitive selection button on empty collection