After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676664 - Don't register modules in a constructor
Don't register modules in a constructor
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-23 16:59 UTC by Giovanni Campagna
Modified: 2012-05-23 17:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Object: don't register modules in a constructor (2.24 KB, patch)
2012-05-23 16:59 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-05-23 16:59:36 UTC 
Registering the private _gi module with the normal macro causes it to be
done before main() and before the app initialized the context.
A side effect of this was that gjs initialized logging before
gnome-shell set up the necessary environment variables, breaking it
unless enabled from outside.
Comment 1 Giovanni Campagna 2012-05-23 16:59:39 UTC 
Created attachment 214793 [details] [review]
Object: don't register modules in a constructor
Comment 2 Colin Walters 2012-05-23 17:11:34 UTC 
Review of attachment 214793 [details] [review]:

Makes sense
Comment 3 Giovanni Campagna 2012-05-23 17:23:57 UTC 
Attachment 214793 [details] pushed as db3219b - Object: don't register modules in a constructor