After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676620 - Problem building with gnome-settings-daemon-uninstalled.pc
Problem building with gnome-settings-daemon-uninstalled.pc
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
3.4.x
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-23 08:07 UTC by Brian Cameron
Modified: 2012-05-23 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch fixing issue. (578 bytes, patch)
2012-05-23 08:07 UTC, Brian Cameron
committed Details | Review

Description Brian Cameron 2012-05-23 08:07:17 UTC
Created attachment 214729 [details] [review]
patch fixing issue.

Solaris uses the uninstalled.pc files to build, and no longer builds because
the location of the needed library changed.  The attached patch fixes the
uninstalled.pc file so it works.
Comment 1 Bastien Nocera 2012-05-23 14:13:21 UTC
Review of attachment 214729 [details] [review]:

Could you please give a git-formatted patch, so as to not lose authorship.
Comment 2 Brian Cameron 2012-05-23 15:33:29 UTC
Sorry, but I am just providing upstream some patches that we wrote internally
to get stuff building.  We normally do our build patches based on tarballs
instead of in git.  I normally run "gpatch urp file1 file2" to build patches.
Is there something you can run to build a git-formatted patch when you are
using the code from a tarball to make a patch?

This is a trivial patch, and contains no interesting authorship.  I claim no
particular ownership over such an obvious 1-line solution.
Comment 3 Bastien Nocera 2012-05-23 15:52:06 UTC
$ git init && git add --ignore-errors .; git commit -m "`basename $PWD`"
[make changes]
$ git commit -a
$ git format-patch -1
[provide patch]