After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676619 - D-Conf should not return a value from a void function
D-Conf should not return a value from a void function
Status: RESOLVED FIXED
Product: dconf
Classification: Core
Component: dconf
0.12.x
Other All
: Normal normal
: ---
Assigned To: dconf-maint
dconf-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-23 08:02 UTC by Brian Cameron
Modified: 2012-07-15 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch fixing issue (342 bytes, patch)
2012-05-23 08:02 UTC, Brian Cameron 		accepted-commit_now Details | Review
Don't return a value from a void function (684 bytes, patch)
2012-07-15 15:53 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Brian Cameron 2012-05-23 08:02:29 UTC 
Created attachment 214728 [details] [review]
patch fixing issue

The do_sync function in tests/gsettings.c returns a value from a void function.  This makes it not compile with the Sun Studio compiler.  Can this be fixed.  I provide a patch.
Comment 1 Matthias Clasen 2012-06-23 20:56:37 UTC 
Review of attachment 214728 [details] [review]:

obviously correct
Comment 2 Allison Karlitskaya (desrt) 2012-07-15 15:53:59 UTC 
Created attachment 218857 [details] [review]
Don't return a value from a void function
Comment 3 Allison Karlitskaya (desrt) 2012-07-15 15:54:43 UTC 
Attachment 218857 [details] pushed as cdf709d - Don't return a value from a void function