GNOME Bugzilla – Bug 676515
[PATCH] Misc cleanups
Last modified: 2012-06-01 14:46:37 UTC
Mostly trivial cleanups that remove some unused code and simplify some other.
Created attachment 214583 [details] [review] share-bar: remove empty finalize method
Created attachment 214584 [details] [review] share-bar: simplify code
Created attachment 214585 [details] [review] user-share: add missing include This is needed for g_rename()
Created attachment 214586 [details] [review] share-extension: remove code that does nothing We keep track of widgets, but don't do anything with them, so just remove this code.
Created attachment 214587 [details] [review] share-extension: remove empty finalize method
Created attachment 214588 [details] [review] share-extension: remove empty private structure
Created attachment 214589 [details] [review] obexpush: don't special case GTK <= 2.14 Since we already depend on > 3.0 in configure.
Created attachment 214590 [details] [review] obexpush: fix a compiler warning
Created attachment 214591 [details] [review] all: don't use deprecated GDK methods https://bugzilla.gnome.org/show_bug.cgi?id=676443
Created attachment 214592 [details] [review] user-share: mark the x_fd variable as unused Fixes a GCC warning about set but not used variables.
Created attachment 214596 [details] [review] share-bar: remove unused nautilus_share_bar_get_button()
Created attachment 214597 [details] [review] share-bar: make the label property write only Since that's all it's needed.
Created attachment 214598 [details] [review] share-bar: don't set italic text We don't favor italic text in the GNOME3 style. Since we already have a bold heading, this is kinda redundant anyway.
Review of attachment 214583 [details] [review]: Yep.
Review of attachment 214584 [details] [review]: Looks good.
Review of attachment 214585 [details] [review]: Yep
Review of attachment 214586 [details] [review]: .
Review of attachment 214587 [details] [review]: .
Review of attachment 214588 [details] [review]: .
Review of attachment 214589 [details] [review]: .
Review of attachment 214590 [details] [review]: ::: src/obexpush.c @@ +213,3 @@ GHashTable *props; + g_message ("checking adapter %s", (gchar *) g_ptr_array_index (adapters, i)); Could you switch that to be g_debug() at the same time please?
Review of attachment 214591 [details] [review]: .
Review of attachment 214592 [details] [review]: .
Review of attachment 214596 [details] [review]: .
Review of attachment 214597 [details] [review]: .
Review of attachment 214598 [details] [review]: .
Attachment 214583 [details] pushed as d1c1de3 - share-bar: remove empty finalize method Attachment 214584 [details] pushed as 532c0b1 - share-bar: simplify code Attachment 214585 [details] pushed as 0a5f5e0 - user-share: add missing include Attachment 214586 [details] pushed as f434976 - share-extension: remove code that does nothing Attachment 214587 [details] pushed as 48a3b06 - share-extension: remove empty finalize method Attachment 214588 [details] pushed as aa18c57 - share-extension: remove empty private structure Attachment 214589 [details] pushed as 4b60c40 - obexpush: don't special case GTK <= 2.14 Attachment 214590 [details] pushed as db151a9 - obexpush: fix a compiler warning Attachment 214591 [details] pushed as 7b51e6c - all: don't use deprecated GDK methods Attachment 214592 [details] pushed as ba5961c - user-share: mark the x_fd variable as unused Attachment 214596 [details] pushed as 71f364b - share-bar: remove unused nautilus_share_bar_get_button() Attachment 214597 [details] pushed as c307a01 - share-bar: make the label property write only Attachment 214598 [details] pushed as 05df1dd - share-bar: don't set italic text