After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676491 - babl_fish_path_dhtml segmentation fault
babl_fish_path_dhtml segmentation fault
Status: RESOLVED OBSOLETE
Product: GEGL
Classification: Other
Component: babl
0.1.0
Other NetBSD
: Normal major
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2012-05-21 12:35 UTC by Julian Coleman
Modified: 2016-02-15 21:31 UTC
See Also:
GNOME target: ---
GNOME version: 2.31/2.32


Attachments
Patch for convert_to_double() segmentation fault (584 bytes, patch)
2012-05-21 12:35 UTC, Julian Coleman
none Details | Review

Description Julian Coleman 2012-05-21 12:35:57 UTC
Created attachment 214560 [details] [review]
Patch for convert_to_double() segmentation fault

When building babl 0.1.10 on NetBSD/sparc64, the generation of
BablFishPath.html in the docs directory fails, because
babl_fish_path_dhtml receives a segmentation fault.

The problem occurs in babl/babl-fish-reference.c:convert_to_double()
because of the call to babl_process() when dst_img->data[0] might be
null.  This happens part way through processing the html, when no
match is found for source_fmt->component[i] when i = 0 (the match
occurs when i = 1 and j = 0).  This causes the call to babl_process()
without first assigning dst_img->data[0] .

The attached patch seems to fix the problem, but I don't know if it's
correct (i.e. is the case where no match is found when i = 0 valid?).
Comment 1 Øyvind Kolås (pippin) 2015-09-17 09:34:36 UTC
Does this still crash on NetBSD/sparc64 (or other 64bit netbsds)?
Comment 2 Øyvind Kolås (pippin) 2016-02-15 21:31:35 UTC
Closing this bug - since no further input has been received and babl seems to operate OK on 64bit on linux.